Small changes

Author: muit

Source/Attributes/Private/AttrModifier.cpp

@@ -31,23 +31,19 @@ FAttrModifier::FAttrModifier(float Increment, float LastValueMultiplier, float B
 
 void FAttrModifier::Apply(float& Value, float BaseValue) const
 {
-	if (!FMath::IsNearlyZero(LastMultiplier))
-	{
-		Value *= 1.0f + LastMultiplier;
-	}
+	Value *= 1.0f + LastMultiplier;
+
 	if (!FMath::IsNearlyZero(BaseMultiplier))
 	{
 		Value += BaseMultiplier * BaseValue;
 	}
 	Value += Increment;
 }
 
-void FAttrModifier::Apply(double& Value, int32 BaseValue) const
+void FAttrModifier::Apply(double& Value, double BaseValue) const
 {
-	if (!FMath::IsNearlyZero(LastMultiplier))
-	{
-		Value *= 1.0 + LastMultiplier;
-	}
+	Value *= 1.0 + LastMultiplier;
+
 	if (!FMath::IsNearlyZero(BaseMultiplier))
 	{
 		Value += BaseMultiplier * BaseValue;

Source/Attributes/Private/Int32Attr.cpp

@@ -38,7 +38,7 @@ void FInt32Attr::InternalRefreshValue(FAttributeChangeInfo&& ChangeInfo)
 	{
 		for (const auto& Mod : Category.Modifiers)
 		{
-			Mod.Apply(TempValue, BaseValue);
+			Mod.Apply(TempValue, double(BaseValue));
 		}
 	}
 

Source/Attributes/Public/AttrModifier.h

@@ -78,11 +78,9 @@ struct ATTRIBUTES_API FAttrModifier
 		return *this;
 	}
 
-	/** Apply changes to the value */
+	/** Applies changes to value */
 	void Apply(float& Value, float BaseValue) const;
-
-	/** Applies the modifier to the value. This version operates as double to avoid int32 precision lose */
-	void Apply(double& Value, int32 BaseValue) const;
+	void Apply(double& Value, double BaseValue) const;
 
 	/** Stack other modifiers values into this mod.
 	 * Now applying this modifier will be equivalent to applying all the others at the same time