Fixed worker task accesing garbage memory

Fix #61

Author: muit

Source/SaveExtension/Private/Serialization/SlotDataTask_Saver.cpp

@@ -172,14 +172,12 @@ void USlotDataTask_Saver::SerializeWorld()
 	const UWorld* World = GetWorld();
 	SELog(Preset, "World '" + World->GetName() + "'", FColor::Green, false, 1);
 
-	BakeAllFilters();
-
 	const TArray<ULevelStreaming*>& Levels = World->GetStreamingLevels();
+	PrepareAllLevels(Levels);
 
 	// Threads available + 1 (Synchronous Thread)
 	const int32 NumberOfThreads = FMath::Max(1, FPlatformMisc::NumberOfWorkerThreadsToSpawn() + 1);
 	const int32 TasksPerLevel = FMath::Max(1, FMath::RoundToInt(float(NumberOfThreads) / (Levels.Num() + 1)));
-
 	Tasks.Reserve(NumberOfThreads);
 
 	SerializeLevelSync(World->GetCurrentLevel(), TasksPerLevel);
@@ -194,6 +192,20 @@ void USlotDataTask_Saver::SerializeWorld()
 	RunScheduledTasks();
 }
 
+void USlotDataTask_Saver::PrepareAllLevels(const TArray<ULevelStreaming*>& Levels)
+{
+	BakeAllFilters();
+
+	// Create the sub-level records if non existent
+	for (const ULevelStreaming* Level : Levels)
+	{
+		if (Level->IsLevelLoaded())
+		{
+			SlotData->SubLevels.AddUnique({ *Level });
+		}
+	}
+}
+
 void USlotDataTask_Saver::SerializeLevelSync(const ULevel* Level, int32 AssignedTasks, const ULevelStreaming* StreamingLevel)
 {
 	TRACE_CPUPROFILER_EVENT_SCOPE(USlotDataTask_Saver::SerializeLevelSync);
@@ -207,14 +219,11 @@ void USlotDataTask_Saver::SerializeLevelSync(const ULevel* Level, int32 Assigned
 	const FName LevelName = StreamingLevel ? StreamingLevel->GetWorldAssetPackageFName() : FPersistentLevelRecord::PersistentName;
 	SELog(Preset, "Level '" + LevelName.ToString() + "'", FColor::Green, false, 1);
 
-
 	// Find level record. By default, main level
 	FLevelRecord* LevelRecord = &SlotData->MainLevel;
 	if (StreamingLevel)
 	{
-		// Find or create the sub-level
-		const int32 Index = SlotData->SubLevels.AddUnique({ *StreamingLevel });
-		LevelRecord = &SlotData->SubLevels[Index];
+		LevelRecord = FindLevelRecord(StreamingLevel);
 	}
 	check(LevelRecord);
 

Source/SaveExtension/Public/Serialization/SlotDataTask_Saver.h

@@ -84,10 +84,13 @@ class USlotDataTask_Saver : public USlotDataTask
 protected:
 
 	/** BEGIN Serialization */
-	void SerializeLevelSync(const ULevel* Level, int32 AssignedThreads, const ULevelStreaming* StreamingLevel = nullptr);
-
 	/** Serializes all world actors. */
 	void SerializeWorld();
+
+	void PrepareAllLevels(const TArray<ULevelStreaming*>& Levels);
+
+	void SerializeLevelSync(const ULevel* Level, int32 AssignedThreads, const ULevelStreaming* StreamingLevel = nullptr);
+
 	/** END Serialization */
 
 	void RunScheduledTasks();