Fixed crash deleting nodes

Author: muit

Libs/Framework/Include/AST/Pool.h

@@ -464,7 +464,7 @@ namespace Rift::AST
 
 
 	public:
-		TPool(AST::Tree& ast) : Pool(ast, DeletionPolicy::InPlace) {}
+		TPool(AST::Tree& ast) : Pool(ast, DeletionPolicy::Swap) {}
 		~TPool() override
 		{
 			Reset();

Libs/Framework/Src/AST/Filtering.cpp

@@ -185,7 +185,7 @@ namespace Rift::AST
 		const Pool* iterablePool = pools[smallestIdx];
 		pools.RemoveAtSwap(smallestIdx);
 
-		ids.Empty();
+		ids.Empty(false);
 		ids.Append(iterablePool->begin(), iterablePool->end());
 
 		for (const Pool* pool : pools)

Libs/Framework/Src/AST/Utils/Statements.cpp

@@ -40,7 +40,6 @@ namespace Rift::AST::Statements
 		else
 		{
 			outputNode = Hierarchy::GetParent(ast, outputPin);
-			Log::Error("{}", outputNode);
 			if (IsNone(outputNode))
 			{
 				return false;

Tests/AST/Filtering.spec.cpp

@@ -41,17 +41,20 @@ go_bandit([]() {
 	AST::Id id2;
 	AST::Id id3;
 	AST::Id id4;
+	AST::Id id5;
 	describe("AST.Filtering", [&]() {
 		before_each([&]() {
 			ast = {};
 			id1 = ast.Create();
 			id2 = ast.Create();
 			id3 = ast.Create();
 			id4 = ast.Create();
+			id5 = ast.Create();
 			ast.Add<Type>(id1);
 			ast.Add<Type, TypeTwo, TypeThree>(id2);
 			ast.Add<TypeTwo, TypeThree>(id3);
 			ast.Add<TypeTwo, TypeThree>(id4);
+			ast.Add<TypeTwo>(id5);
 		});
 
 		describe("ListAny/ListAll", [&]() {
@@ -84,10 +87,12 @@ go_bandit([]() {
 			it("Doesn't list removed ids", [&]() {
 				TAccess<TypeTwo> access{ast};
 				ast.Destroy(id2);    // Remove first in the pool
+				ast.Destroy(id3);    // Remove last in the pool
 				ast.Destroy(id4);    // Remove last in the pool
 
 				TArray<AST::Id> ids = AST::ListAll<TypeTwo>(access);
 				AssertThat(ids.Contains(AST::NoId), Is().False());
+				AssertThat(ids.Size(), Equals(1));
 			});
 		});