Skip to content

Commit 29dba7f

Browse files
Li QiongUlrich Hecht
authored andcommitted
mm/slub: avoid accessing metadata when pointer is invalid in object_err()
[ Upstream commit b4efccec8d06ceb10a7d34d7b1c449c569d53770 ] object_err() reports details of an object for further debugging, such as the freelist pointer, redzone, etc. However, if the pointer is invalid, attempting to access object metadata can lead to a crash since it does not point to a valid object. One known path to the crash is when alloc_consistency_checks() determines the pointer to the allocated object is invalid because of a freelist corruption, and calls object_err() to report it. The debug code should report and handle the corruption gracefully and not crash in the process. In case the pointer is NULL or check_valid_pointer() returns false for the pointer, only print the pointer value and skip accessing metadata. Fixes: 81819f0 ("SLUB core") Cc: <stable@vger.kernel.org> Signed-off-by: Li Qiong <liqiong@nfschina.com> Reviewed-by: Harry Yoo <harry.yoo@oracle.com> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org> Signed-off-by: Vlastimil Babka <vbabka@suse.cz> [ struct page + print_page_info() ] Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Ulrich Hecht <uli@kernel.org>
1 parent b930a4e commit 29dba7f

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

mm/slub.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -706,7 +706,12 @@ void object_err(struct kmem_cache *s, struct page *page,
706706
u8 *object, char *reason)
707707
{
708708
slab_bug(s, "%s", reason);
709-
print_trailer(s, page, object);
709+
if (!object || !check_valid_pointer(s, page, object)) {
710+
print_page_info(page);
711+
pr_err("Invalid pointer 0x%p\n", object);
712+
} else {
713+
print_trailer(s, page, object);
714+
}
710715
}
711716

712717
static __printf(3, 4) void slab_err(struct kmem_cache *s, struct page *page,

0 commit comments

Comments
 (0)