ASoC: qdsp6: q6asm: do not sleep while atomic

Srinivas Kandagatla · Ulrich Hecht · commit 4f2ba8494247 · 2025-12-22T04:34:04.000+01:00
commit fdbb53d318aa94a094434e5f226617f0eb1e8f22 upstream. For some reason we ended up kfree between spinlock lock and unlock, which can sleep. move the kfree out of spinlock section. Fixes: a2a5d30 ("ASoC: qdsp6: q6asm: Add support to memory map and unmap") Cc: Stable@vger.kernel.org Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com> Link: https://patch.msgid.link/20251017085307.4325-2-srinivas.kandagatla@oss.qualcomm.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Ulrich Hecht <uli@kernel.org>
diff --git a/sound/soc/qcom/qdsp6/q6asm.c b/sound/soc/qcom/qdsp6/q6asm.c
@@ -298,9 +298,9 @@ static void q6asm_audio_client_free_buf(struct audio_client *ac,
 
 	spin_lock_irqsave(&ac->lock, flags);
 	port->num_periods = 0;
+	spin_unlock_irqrestore(&ac->lock, flags);
 	kfree(port->buf);
 	port->buf = NULL;
-	spin_unlock_irqrestore(&ac->lock, flags);
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -298,9 +298,9 @@ static void q6asm_audio_client_free_buf(struct audio_client *ac,`
`298`	`298`
`299`	`299`	`spin_lock_irqsave(&ac->lock, flags);`
`300`	`300`	`port->num_periods = 0;`
	`301`	`+ spin_unlock_irqrestore(&ac->lock, flags);`
`301`	`302`	`kfree(port->buf);`
`302`	`303`	`port->buf = NULL;`
`303`		`- spin_unlock_irqrestore(&ac->lock, flags);`
`304`	`304`	`}`
`305`	`305`
`306`	`306`	`/**`