Skip to content

Commit c5b54c0

Browse files
Kemeng ShiUlrich Hecht
authored andcommitted
ext4: remove unused return value of __mb_check_buddy
[ Upstream commit 133de5a0d8f8e32b34feaa8beae7a189482f1856 ] Remove unused return value of __mb_check_buddy. Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Reviewed-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20240105092102.496631-2-shikemeng@huaweicloud.com Signed-off-by: Theodore Ts'o <tytso@mit.edu> Stable-dep-of: d9ee3ff810f1 ("ext4: improve integrity checking in __mb_check_buddy by enhancing order-0 validation") Signed-off-by: Sasha Levin <sashal@kernel.org> [uli: backport to 4.19] Signed-off-by: Ulrich Hecht <uli@kernel.org> Reviewed-by: Pavel Machek <pavel@nabladev.com>
1 parent 5d3fef3 commit c5b54c0

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

fs/ext4/mballoc.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,7 @@ do { \
541541
} \
542542
} while (0)
543543

544-
static int __mb_check_buddy(struct ext4_buddy *e4b, char *file,
544+
static void __mb_check_buddy(struct ext4_buddy *e4b, char *file,
545545
const char *function, int line)
546546
{
547547
struct super_block *sb = e4b->bd_sb;
@@ -562,7 +562,7 @@ static int __mb_check_buddy(struct ext4_buddy *e4b, char *file,
562562
{
563563
static int mb_check_counter;
564564
if (mb_check_counter++ % 100 != 0)
565-
return 0;
565+
return;
566566
}
567567

568568
while (order > 1) {
@@ -638,7 +638,6 @@ static int __mb_check_buddy(struct ext4_buddy *e4b, char *file,
638638
for (i = 0; i < pa->pa_len; i++)
639639
MB_CHECK_ASSERT(mb_test_bit(k + i, buddy));
640640
}
641-
return 0;
642641
}
643642
#undef MB_CHECK_ASSERT
644643
#define mb_check_buddy(e4b) __mb_check_buddy(e4b, \

0 commit comments

Comments
 (0)