Skip to content

Commit 418f7ed

Browse files
author
Anthony Alridge
committed
Revert "Update String in CTS to align with updated behaviour of managed device."
This reverts commit 298bb00. Reason for revert: This removes the string arguments and replaces with a static string for all test cases, which breaks the instructions for all but the "disallow add user" test. To update strings for disallow_add_users specifically, then please edit the "disallow_add_user_action" string resource only. Bug: 312647568 Change-Id: Ie32034edd2b8c8252ea7a870b093c9b2b843d7b3
1 parent 298bb00 commit 418f7ed

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

apps/CtsVerifier/res/values/strings.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4455,8 +4455,9 @@ You should be prompted to select credentials; choose the ones you just installed
44554455
<string name="test_accessibility_service_label">Test accessibility service</string>
44564456
<string name="policy_transparency_test_instructions">
44574457
1. <xliff:g id="set_step" example="Set policy by turning the switch on">%1$s</xliff:g>\n
4458-
2. Open Settings app by clicking the \"Open settings\" button below. Note that this will open the personal Settings app. If this device has the work settings in a different app or screen, then navigate there, ignoring the button if necessary.\n
4459-
3. Verify that clicking on \"Allow multiple users\" toggle will trigger a support dialog.\n
4458+
2. Open Settings app by clicking the "Open settings" button below. Note that this will open the personal Settings app. If this device has the work settings in a different app or screen, then navigate there, ignoring the button if necessary.\n
4459+
3. Verify that performing the following action will trigger a support dialog:\n
4460+
<xliff:g id="user_action" example="Adding an account">%2$s</xliff:g>.<xliff:g id="exception_node" example="NOTE: if the device doesn't support the action...">%3$s</xliff:g>\n
44604461
4. Verify that the support dialog displays the short support message set earlier.\n
44614462
</string>
44624463
<string name="optional_policy_transparency_test_note">\n\t<b>NOTE</b>: if the device doesn\'t support this action please skip this test and mark it as passing.</string>

apps/CtsVerifier/src/com/android/cts/verifier/managedprovisioning/PolicyTransparencyTestActivity.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,8 @@ private void updateTestInstructions() {
172172
}
173173
((TextView) findViewById(R.id.widget_label)).setText(widgetLabel);
174174
((TextView) findViewById(R.id.test_instructions)).setText(
175-
getString(R.string.policy_transparency_test_instructions, setStep));
175+
getString(R.string.policy_transparency_test_instructions,
176+
setStep, userAction, note));
176177
updateWidget(widgetId);
177178
}
178179

0 commit comments

Comments
 (0)