Skip to content

Commit 72475ac

Browse files
shuzhenwangGerrit Code Review
authored andcommitted
Merge "Camera: Update MULTI_CAMERA requirement in MPC" into android14-tests-dev
2 parents b6cfdac + 71c3116 commit 72475ac

2 files changed

Lines changed: 6 additions & 21 deletions

File tree

tests/camera/src/android/hardware/camera2/cts/ExtendedCameraCharacteristicsTest.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3583,14 +3583,12 @@ && hasUndefinedPoseReferenceWithSameFacing(cameraId, staticInfo))
35833583
}
35843584

35853585
// H-1-13
3586-
int facing = staticInfo.getLensFacingChecked();
3587-
int numOfPhysicalRgbCameras = getNumberOfRgbPhysicalCameras(facing);
3588-
boolean logicalMultiCameraReqMet =
3589-
(numOfPhysicalRgbCameras <= 1) || staticInfo.isLogicalMultiCamera();
35903586
if (isPrimaryRear) {
3587+
int facing = staticInfo.getLensFacingChecked();
3588+
int numOfPhysicalRgbCameras = getNumberOfRgbPhysicalCameras(facing);
3589+
boolean logicalMultiCameraReqMet =
3590+
(numOfPhysicalRgbCameras <= 1) || staticInfo.isLogicalMultiCamera();
35913591
logicalMultiCameraReq.setRearLogicalMultiCameraReqMet(logicalMultiCameraReqMet);
3592-
} else {
3593-
logicalMultiCameraReq.setFrontLogicalMultiCameraReqMet(logicalMultiCameraReqMet);
35943592
}
35953593

35963594
// H-1-14
@@ -3627,7 +3625,6 @@ && hasUndefinedPoseReferenceWithSameFacing(cameraId, staticInfo))
36273625
CameraMetadata.SENSOR_INFO_TIMESTAMP_SOURCE_UNKNOWN);
36283626
ultrawideZoomRatioReq.setFrontUltraWideZoomRatioReqMet(false);
36293627
previewStabilizationReq.setFrontPreviewStabilizationSupported(false);
3630-
logicalMultiCameraReq.setFrontLogicalMultiCameraReqMet(false);
36313628
streamUseCaseReq.setFrontStreamUseCaseSupported(false);
36323629
}
36333630

tests/mediapc/common/src/android/mediapc/cts/common/PerformanceClassEvaluator.java

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1516,14 +1516,9 @@ public void setRearLogicalMultiCameraReqMet(boolean reqMet) {
15161516
reqMet);
15171517
}
15181518

1519-
public void setFrontLogicalMultiCameraReqMet(boolean reqMet) {
1520-
this.setMeasuredValue(RequirementConstants.FRONT_CAMERA_LOGICAL_MULTI_CAMERA_REQ_MET,
1521-
reqMet);
1522-
}
1523-
15241519
/**
15251520
* [2.2.7.2/7.5/H-1-13] MUST support LOGICAL_MULTI_CAMERA capability for the primary
1526-
* cameras if there are greater than 1 RGB cameras facing the same direction.
1521+
* rear-facing camera if there are greater than 1 RGB rear-facing cameras.
15271522
*/
15281523
public static LogicalMultiCameraRequirement createLogicalMultiCameraReq() {
15291524
RequiredMeasurement<Boolean> rearRequirement = RequiredMeasurement
@@ -1533,16 +1528,9 @@ public static LogicalMultiCameraRequirement createLogicalMultiCameraReq() {
15331528
.addRequiredValue(Build.VERSION_CODES.TIRAMISU, true)
15341529
.addRequiredValue(Build.VERSION_CODES.UPSIDE_DOWN_CAKE, true)
15351530
.build();
1536-
RequiredMeasurement<Boolean> frontRequirement = RequiredMeasurement
1537-
.<Boolean>builder()
1538-
.setId(RequirementConstants.FRONT_CAMERA_LOGICAL_MULTI_CAMERA_REQ_MET)
1539-
.setPredicate(RequirementConstants.BOOLEAN_EQ)
1540-
.addRequiredValue(Build.VERSION_CODES.TIRAMISU, true)
1541-
.addRequiredValue(Build.VERSION_CODES.UPSIDE_DOWN_CAKE, true)
1542-
.build();
15431531

15441532
return new LogicalMultiCameraRequirement(RequirementConstants.R7_5__H_1_13,
1545-
rearRequirement, frontRequirement);
1533+
rearRequirement);
15461534
}
15471535
}
15481536

0 commit comments

Comments
 (0)