Skip to content

Commit dcf8716

Browse files
Merge "Camera: Update MULTI_CAMERA requirement in MPC" into android13-tests-dev am: 6c732b0 am: 9eb0c88
Original change: https://android-review.googlesource.com/c/platform/cts/+/2853005 Change-Id: Ic35c061fa562c474007aa62f9296cdf7819090e7 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2 parents 19bb420 + 9eb0c88 commit dcf8716

2 files changed

Lines changed: 6 additions & 20 deletions

File tree

tests/camera/src/android/hardware/camera2/cts/ExtendedCameraCharacteristicsTest.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3085,14 +3085,12 @@ && hasUndefinedPoseReferenceWithSameFacing(cameraId, staticInfo))
30853085
}
30863086

30873087
// H-1-13
3088-
int facing = staticInfo.getLensFacingChecked();
3089-
int numOfPhysicalRgbCameras = getNumberOfRgbPhysicalCameras(facing);
3090-
boolean logicalMultiCameraReqMet =
3091-
(numOfPhysicalRgbCameras <= 1) || staticInfo.isLogicalMultiCamera();
30923088
if (isPrimaryRear) {
3089+
int facing = staticInfo.getLensFacingChecked();
3090+
int numOfPhysicalRgbCameras = getNumberOfRgbPhysicalCameras(facing);
3091+
boolean logicalMultiCameraReqMet =
3092+
(numOfPhysicalRgbCameras <= 1) || staticInfo.isLogicalMultiCamera();
30933093
logicalMultiCameraReq.setRearLogicalMultiCameraReqMet(logicalMultiCameraReqMet);
3094-
} else {
3095-
logicalMultiCameraReq.setFrontLogicalMultiCameraReqMet(logicalMultiCameraReqMet);
30963094
}
30973095

30983096
// H-1-14
@@ -3129,7 +3127,6 @@ && hasUndefinedPoseReferenceWithSameFacing(cameraId, staticInfo))
31293127
CameraMetadata.SENSOR_INFO_TIMESTAMP_SOURCE_UNKNOWN);
31303128
ultrawideZoomRatioReq.setFrontUltraWideZoomRatioReqMet(false);
31313129
previewStabilizationReq.setFrontPreviewStabilizationSupported(false);
3132-
logicalMultiCameraReq.setFrontLogicalMultiCameraReqMet(false);
31333130
streamUseCaseReq.setFrontStreamUseCaseSupported(false);
31343131
}
31353132

tests/mediapc/common/src/android/mediapc/cts/common/PerformanceClassEvaluator.java

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1431,14 +1431,9 @@ public void setRearLogicalMultiCameraReqMet(boolean reqMet) {
14311431
reqMet);
14321432
}
14331433

1434-
public void setFrontLogicalMultiCameraReqMet(boolean reqMet) {
1435-
this.setMeasuredValue(RequirementConstants.FRONT_CAMERA_LOGICAL_MULTI_CAMERA_REQ_MET,
1436-
reqMet);
1437-
}
1438-
14391434
/**
14401435
* [2.2.7.2/7.5/H-1-13] MUST support LOGICAL_MULTI_CAMERA capability for the primary
1441-
* cameras if there are greater than 1 RGB cameras facing the same direction.
1436+
* rear-facing camera if there are greater than 1 RGB rear-facing cameras.
14421437
*/
14431438
public static LogicalMultiCameraRequirement createLogicalMultiCameraReq() {
14441439
RequiredMeasurement<Boolean> rearRequirement = RequiredMeasurement
@@ -1447,15 +1442,9 @@ public static LogicalMultiCameraRequirement createLogicalMultiCameraReq() {
14471442
.setPredicate(RequirementConstants.BOOLEAN_EQ)
14481443
.addRequiredValue(Build.VERSION_CODES.TIRAMISU, true)
14491444
.build();
1450-
RequiredMeasurement<Boolean> frontRequirement = RequiredMeasurement
1451-
.<Boolean>builder()
1452-
.setId(RequirementConstants.FRONT_CAMERA_LOGICAL_MULTI_CAMERA_REQ_MET)
1453-
.setPredicate(RequirementConstants.BOOLEAN_EQ)
1454-
.addRequiredValue(Build.VERSION_CODES.TIRAMISU, true)
1455-
.build();
14561445

14571446
return new LogicalMultiCameraRequirement(RequirementConstants.R7_5__H_1_13,
1458-
rearRequirement, frontRequirement);
1447+
rearRequirement);
14591448
}
14601449
}
14611450

0 commit comments

Comments
 (0)