Skip to content

Commit e150689

Browse files
Shunkai YaoGerrit Code Review
authored andcommitted
Merge "Revert "CtsMediaTestCases: AudioEffects: takes initial state into account"" into android13-tests-dev
2 parents e9cc1bd + 7492316 commit e150689

2 files changed

Lines changed: 0 additions & 67 deletions

File tree

tests/tests/media/audio/src/android/media/audio/cts/AudioEffectTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ public class AudioEffectTest extends PostProcTestBase {
6666

6767
@Override
6868
protected void tearDown() throws Exception {
69-
super.tearDown();
7069
releaseEffect();
7170
terminateMediaPlayerLooper();
7271
terminateListenerLooper();
@@ -672,7 +671,6 @@ public void test4_0setEnabledLowerPriority() throws Exception {
672671
assertFalse("Effect1 has control", effect1.hasControl());
673672
assertTrue("Effect1 can enable",
674673
effect1.setEnabled(true) == AudioEffect.ERROR_INVALID_OPERATION);
675-
// Note: all effects under test are disabled at setup
676674
assertFalse("Effect1 has enabled", effect2.getEnabled());
677675

678676
} catch (IllegalArgumentException e) {

tests/tests/media/common/src/android/media/cts/PostProcTestBase.java

Lines changed: 0 additions & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,7 @@
2323
import android.os.Looper;
2424
import android.test.AndroidTestCase;
2525

26-
import java.lang.Boolean;
27-
import java.util.HashMap;
28-
import java.util.Map;
29-
import java.util.UUID;
30-
3126
public class PostProcTestBase extends AndroidTestCase {
32-
private static final int CONTROL_PRIORITY = 100;
33-
3427
protected int mSession = -1;
3528
protected boolean mHasControl = false;
3629
protected boolean mIsEnabled = false;
@@ -41,64 +34,6 @@ public class PostProcTestBase extends AndroidTestCase {
4134
protected final static String BUNDLE_VOLUME_EFFECT_UUID =
4235
"119341a0-8469-11df-81f9-0002a5d5c51b";
4336

44-
private Map<UUID, Boolean> mOriginalEffectState = new HashMap<>();
45-
46-
/**
47-
* All potential effects under test are disabled at setup.
48-
* Initial state is backuped, restored in tearDown
49-
* @throws Exception
50-
*/
51-
@Override
52-
protected void setUp() throws Exception {
53-
super.setUp();
54-
55-
final UUID[] effectTypes = {
56-
AudioEffect.EFFECT_TYPE_BASS_BOOST,
57-
AudioEffect.EFFECT_TYPE_EQUALIZER,
58-
AudioEffect.EFFECT_TYPE_VIRTUALIZER,
59-
AudioEffect.EFFECT_TYPE_PRESET_REVERB,
60-
AudioEffect.EFFECT_TYPE_ENV_REVERB,
61-
};
62-
for (UUID effectType : effectTypes) {
63-
try {
64-
if (AudioEffect.isEffectTypeAvailable(effectType)) {
65-
AudioEffect effect = new AudioEffect(effectType,
66-
AudioEffect.EFFECT_TYPE_NULL,
67-
CONTROL_PRIORITY,
68-
0);
69-
assertTrue("effect does not have control", effect.hasControl());
70-
mOriginalEffectState.put(effectType, effect.getEnabled());
71-
72-
effect.setEnabled(false);
73-
assertFalse("Could not disable effect", effect.getEnabled());
74-
effect.release();
75-
}
76-
} catch (IllegalStateException e) {
77-
} catch (IllegalArgumentException e) {
78-
} catch (UnsupportedOperationException e) {
79-
}
80-
}
81-
}
82-
83-
@Override
84-
protected void tearDown() throws Exception {
85-
super.tearDown();
86-
for (Map.Entry<UUID, Boolean> entry : mOriginalEffectState.entrySet()) {
87-
try {
88-
AudioEffect effect = new AudioEffect(entry.getKey(),
89-
AudioEffect.EFFECT_TYPE_NULL,
90-
CONTROL_PRIORITY,
91-
0);
92-
assertTrue("effect does not have control", effect.hasControl());
93-
effect.setEnabled(entry.getValue());
94-
effect.release();
95-
} catch (IllegalStateException e) {
96-
} catch (IllegalArgumentException e) {
97-
} catch (UnsupportedOperationException e) {
98-
}
99-
}
100-
}
101-
10237
protected boolean hasAudioOutput() {
10338
return getContext().getPackageManager().hasSystemFeature(
10439
PackageManager.FEATURE_AUDIO_OUTPUT);

0 commit comments

Comments
 (0)