NetworkPolicyManagerService: Avoid OOB in addSdkSandboxUidsIfNeeded

java.lang.ArrayIndexOutOfBoundsException: Array index out of range: 524
        at android.util.SparseIntArray.keyAt(SparseIntArray.java:183)
        at com.android.server.net.NetworkPolicyManagerService.addSdkSandboxUidsIfNeeded(NetworkPolicyManagerService.java:5978)
        at com.android.server.net.NetworkPolicyManagerService.setUidFirewallRulesUL(NetworkPolicyManagerService.java:5998)
        at com.android.server.net.NetworkPolicyManagerService.updateRestrictedModeAllowlistUL(NetworkPolicyManagerService.java:4450)
        at com.android.server.net.NetworkPolicyManagerService$12.onAvailable(NetworkPolicyManagerService.java:1450)
        at android.net.ConnectivityManager$NetworkCallback.onAvailable(ConnectivityManager.java:3823)
        at android.net.ConnectivityManager$NetworkCallback.onAvailable(ConnectivityManager.java:3805)
        at android.net.ConnectivityManager$CallbackHandler.handleMessage(ConnectivityManager.java:4132)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loopOnce(Looper.java:201)
        at android.os.Looper.loop(Looper.java:288)
        at android.os.HandlerThread.run(HandlerThread.java:67)
        at com.android.server.ServiceThread.run(ServiceThread.java:44)

Change-Id: I500f4c7b3c4bc7609c494e4ab8763389a3f2bdbb

Author: adithya2306

services/core/java/com/android/server/net/NetworkPolicyManagerService.java

@@ -5705,11 +5705,11 @@ private void setUidFirewallRulesUL(int chain, @Nullable SparseIntArray uidRules,
     }
 
     private void addSdkSandboxUidsIfNeeded(SparseIntArray uidRules) {
-        final int size = uidRules.size();
+        final SparseIntArray rules = uidRules.clone();
         final SparseIntArray sdkSandboxUids = new SparseIntArray();
-        for (int index = 0; index < size; index++) {
-            final int uid = uidRules.keyAt(index);
-            final int rule = uidRules.valueAt(index);
+        for (int index = 0; index < rules.size(); index++) {
+            final int uid = rules.keyAt(index);
+            final int rule = rules.valueAt(index);
             if (Process.isApplicationUid(uid)) {
                 sdkSandboxUids.put(Process.toSdkSandboxUid(uid), rule);
             }
@@ -5728,8 +5728,8 @@ private void addSdkSandboxUidsIfNeeded(SparseIntArray uidRules) {
      * specified here.
      */
     private void setUidFirewallRulesUL(int chain, SparseIntArray uidRules) {
-        addSdkSandboxUidsIfNeeded(uidRules);
         try {
+            addSdkSandboxUidsIfNeeded(uidRules);
             int size = uidRules.size();
             int[] uids = new int[size];
             int[] rules = new int[size];