Merge pull request #629 from PolymathNetwork/fix/providers-emails

chore(issuer): catch all email errors, instead of provider apps' only

Author: FahdW

packages/polymath-offchain/src/routes/providers.js

@@ -227,38 +227,34 @@ export const applyHandler = async (ctx: Context) => {
     otherDetails,
   };
 
-  try {
-    const { name: userName, email: userEmail } = user;
-    if (
-      DEPLOYMENT_STAGE === 'production' &&
-      NETWORKS[networkId].name === 'mainnet'
-    ) {
-      // Send emails to all selected providers
-      const providers = await Provider.find({ id: { $in: ids } });
-      for (let provider of providers) {
-        const { name: providerName, email: providerEmail } = provider;
-        await sendProviderApplicationEmail(
-          providerEmail,
-          providerName,
-          userName,
-          userEmail,
-          application,
-          false
-        );
-      }
-    } else {
-      // Send dummy email to the issuer instead of the provider
+  const { name: userName, email: userEmail } = user;
+  if (
+    DEPLOYMENT_STAGE === 'production' &&
+    NETWORKS[networkId].name === 'mainnet'
+  ) {
+    // Send emails to all selected providers
+    const providers = await Provider.find({ id: { $in: ids } });
+    for (let provider of providers) {
+      const { name: providerName, email: providerEmail } = provider;
       await sendProviderApplicationEmail(
-        userEmail,
-        userName,
+        providerEmail,
+        providerName,
         userName,
         userEmail,
         application,
-        true
+        false
       );
     }
-  } catch (error) {
-    console.error('Sendgrid error:', error, error.response.body.errors);
+  } else {
+    // Send dummy email to the issuer instead of the provider
+    await sendProviderApplicationEmail(
+      userEmail,
+      userName,
+      userName,
+      userEmail,
+      application,
+      true
+    );
   }
 
   ctx.body = {

packages/polymath-offchain/src/utils/emails.js

@@ -49,7 +49,13 @@ export const sendEmail = async (
     html: body,
   };
   if (SENDGRID_API_KEY) {
-    await sgMail.send(msg);
+    try {
+      await sgMail.send(msg);
+    } catch (error) {
+      logger.error('SendGrid error:', error.response.body.errors);
+      // Still throw the error in order to send it to Sentry.
+      throw error;
+    }
   } else {
     logger.warn('Not sending email since SENDGRID_API_KEY is not set.');
     logger.warn(JSON.stringify(msg));