Added note placement effect

Small particle effects spawn on note queue and placed note
Fixed some spaghetti with initial noteArrow position

Author: LifeHckr

scenes/BattleDirector/notePoofParticles.tscn

@@ -0,0 +1,33 @@
+[gd_scene load_steps=5 format=3 uid="uid://k21psn7b5sxf"]
+
+[ext_resource type="Texture2D" uid="uid://cdf3g3174du4r" path="res://Classes/Notes/assets/heal_note.png" id="1_hjrch"]
+
+[sub_resource type="Curve" id="Curve_xix4e"]
+_data = [Vector2(0, 1), 0.0, 1.4, 0, 0, Vector2(1, 0), 0.0, 0.0, 0, 0]
+point_count = 2
+
+[sub_resource type="CurveTexture" id="CurveTexture_h7u0t"]
+curve = SubResource("Curve_xix4e")
+
+[sub_resource type="ParticleProcessMaterial" id="ParticleProcessMaterial_k0qar"]
+lifetime_randomness = 0.25
+particle_flag_disable_z = true
+emission_shape = 2
+emission_sphere_radius = 3.0
+spread = 180.0
+initial_velocity_min = 30.77
+initial_velocity_max = 61.55
+gravity = Vector3(0, 0, 0)
+tangential_accel_min = -100.0
+tangential_accel_max = 85.12
+scale_curve = SubResource("CurveTexture_h7u0t")
+
+[node name="NotePoof" type="GPUParticles2D"]
+emitting = false
+amount = 10
+process_material = SubResource("ParticleProcessMaterial_k0qar")
+texture = ExtResource("1_hjrch")
+lifetime = 0.75
+one_shot = true
+preprocess = 0.1
+explosiveness = 1.0

scenes/BattleDirector/scripts/Conductor.cs

@@ -56,6 +56,7 @@ public bool AddNoteToLane(ArrowType type, int beat, Note note, bool isActive = t
         else
         {
             arrow = CM.AddArrowToLane(type, beat, newNote, new Color(1, 0.43f, 0.26f));
+            NoteQueueParticlesFactory.NoteParticles(arrow, note.Texture, .5f);
         }
 
         if (!isActive)

scenes/BattleDirector/scripts/NotePlacementBar.cs

@@ -135,15 +135,19 @@ private void UpdateNoteQueue()
     private Note GetNote(bool getNextNote = false)
     {
         Note result;
+        Sprite2D selectedNote;
         if (!getNextNote)
         {
+            selectedNote = _currentNote;
             result = _currentNoteInstance;
             _currentNoteInstance = null;
         }
         else
         {
+            selectedNote = _nextNote;
             result = _noteQueue.Dequeue();
         }
+        NoteQueueParticlesFactory.NoteParticles(selectedNote, selectedNote.Texture);
         ProgressQueue();
         return result;
     }
@@ -156,7 +160,6 @@ public void HitNote()
         _currentBarValue = Math.Min(_currentBarValue + comboMult, MaxValue);
         UpdateNotePlacementBar(_currentBarValue);
         UpdateComboMultText();
-        //fullBarParticles.Emitting = CanPlaceNote();
     }
 
     // Missing a note resets combo

scenes/BattleDirector/scripts/NoteQueueParticlesFactory.cs

@@ -0,0 +1,28 @@
+using System;
+using Godot;
+
+public static class NoteQueueParticlesFactory
+{
+    private static PackedScene particlesScene = null;
+
+    public static GpuParticles2D NoteParticles(
+        Node parent,
+        Texture2D texture,
+        float amountModifier = 1
+    )
+    {
+        particlesScene ??= GD.Load<PackedScene>(
+            "res://scenes/BattleDirector/notePoofParticles.tscn"
+        );
+
+        GpuParticles2D particles = particlesScene.Instantiate<GpuParticles2D>();
+
+        parent.AddChild(particles);
+        particles.Amount = (int)(particles.Amount * amountModifier);
+        particles.Texture = texture;
+        particles.Emitting = true;
+        particles.Finished += () => particles.QueueFree();
+
+        return particles;
+    }
+}

scenes/ChartViewport/scripts/ChartManager.cs

@@ -110,14 +110,13 @@ private NoteArrow CreateNote(ArrowType arrow, Note note, int beat = 0, int loopO
     {
         var noteScene = ResourceLoader.Load<PackedScene>("res://scenes/NoteManager/note.tscn");
         NoteArrow newArrow = noteScene.Instantiate<NoteArrow>();
+        newArrow.Bounds = (float)(
+            beat / TrueBeatsPerLoop * (ChartLength / 2) + loopOffset * (ChartLength / 2)
+        );
         newArrow.Init(IH.Arrows[(int)arrow], beat, note);
         newArrow.OutlineSprite.Modulate = IH.Arrows[(int)arrow].Color;
 
         _arrowGroup.AddChild(newArrow);
-        newArrow.Bounds = (float)(
-            beat / TrueBeatsPerLoop * (ChartLength / 2) + loopOffset * (ChartLength / 2)
-        );
-        newArrow.Position += Vector2.Right * newArrow.Bounds * 10; //temporary fix for notes spawning and instantly calling loop from originating at 0,0
         return newArrow;
     }
 

scenes/NoteManager/scripts/NoteArrow.cs

@@ -26,7 +26,7 @@ public void Init(ArrowData parentArrowData, int beat, Note note)
         Type = parentArrowData.Type;
         Beat = beat;
 
-        Position += Vector2.Down * (parentArrowData.Node.GlobalPosition.Y);
+        Position = new Vector2(GetNewPos(), parentArrowData.Node.GlobalPosition.Y);
         RotationDegrees = parentArrowData.Node.RotationDegrees;
         IconSprite.Texture = note.Texture;
         IconSprite.Rotation = -Rotation;
@@ -35,19 +35,23 @@ public void Init(ArrowData parentArrowData, int beat, Note note)
     public override void _Process(double delta)
     {
         Vector2 newPos = Position;
-        newPos.X =
-            (float)(
-                (-TimeKeeper.CurrentTime / TimeKeeper.LoopLength * TimeKeeper.ChartLength)
-                % TimeKeeper.ChartLength
-                / 2
-            ) + Bounds;
+        newPos.X = GetNewPos();
         if (newPos.X > Position.X)
         {
             OnLoop();
         }
         Position = newPos;
     }
 
+    private float GetNewPos()
+    {
+        return (float)(
+                (-TimeKeeper.CurrentTime / TimeKeeper.LoopLength * TimeKeeper.ChartLength)
+                % TimeKeeper.ChartLength
+                / 2
+            ) + Bounds;
+    }
+
     private void OnLoop()
     {
         if (!IsActive)