Finalizing tweaks

Clean up comments and TODO's
Fix ChartLooped getting called multiple times due to modulo of int instead of float

Author: LifeHckr

Classes/Notes/Note.cs

@@ -13,7 +13,7 @@ public partial class Note : Resource, IDisplayable
     public string Name { get; set; }
     private int _baseVal;
     public float CostModifier { get; private set; }
-    private Action<BattleDirector, Note, Timing> NoteEffect; //TODO: Where/How to deal with timing.
+    private Action<BattleDirector, Note, Timing> NoteEffect;
 
     public string Tooltip { get; set; }
     public Texture2D Texture { get; set; }

Classes/Relics/RelicTemplate.cs

@@ -16,11 +16,11 @@ public RelicTemplate(
         string name = "",
         string tooltip = "",
         Texture2D texture = null,
-        RelicEffect[] EffectTags = null
+        RelicEffect[] effectTags = null
     )
     {
         Id = id;
-        Effects = EffectTags;
+        Effects = effectTags;
         Name = name;
         Tooltip = tooltip;
         Texture = texture;

Globals/StageProducer.cs

@@ -10,7 +10,7 @@ public partial class StageProducer : Node
     public static RandomNumberGenerator GlobalRng = new RandomNumberGenerator();
     public static bool IsInitialized;
 
-    private Stages _curStage = Stages.Title; //TODO: State Machine kinda deal?
+    private Stages _curStage = Stages.Title;
     private Node _curScene;
     public static int CurRoom { get; private set; }
 
@@ -20,7 +20,6 @@ public partial class StageProducer : Node
     public static BattleConfig Config;
 
     //Hold here to persist between changes
-    //TODO: Allow for permanent changes and battle temporary stat changes.
     public static PlayerStats PlayerStats;
 
     public static CanvasLayer ContrastFilter;

SaveData/SaveSystem.cs

@@ -106,7 +106,7 @@ private static void LoadConfigData()
         VerifyConfig();
         if (_curConfigData.Load(UserConfigPath) == Error.Ok)
             return;
-        GD.Print("No config could be found, creating a new one.");
+        GD.PushWarning("Safe. No config could be found, creating a new one.");
         InitConfig();
         SaveConfig();
     }
@@ -187,8 +187,6 @@ public static void SaveGame()
 
         FileAccess file = FileAccess.Open(UserSavePath, FileAccess.ModeFlags.Write);
 
-        GD.Print(json);
-
         file.StoreLine(json);
         file.Close();
     }
@@ -200,8 +198,6 @@ public static SaveFile LoadGame()
         FileAccess file = FileAccess.Open(UserSavePath, FileAccess.ModeFlags.Read);
         string json = file.GetAsText();
 
-        GD.Print(json);
-
         file.Close();
         SaveFile sv;
         try

scenes/BattleDirector/scripts/BattleDirector.cs

@@ -10,7 +10,7 @@
  * @brief Higher priority director to manage battle effects. Can directly access managers, which should signal up to Director WIP
  */
 public partial class BattleDirector : Node2D
-{ //TODO: Maybe move some Director functionality to a sub node.
+{
     #region Declarations
 
     public PlayerPuppet Player;
@@ -70,7 +70,6 @@ public PuppetTemplate GetTarget(Note note)
     #region Initialization
     public override void _Ready()
     {
-        //TODO: Should come from transition into battle
         _curSong = StageProducer.Config.CurSong.SongData;
         Audio.SetStream(GD.Load<AudioStream>(StageProducer.Config.CurSong.AudioLocation));
         if (_curSong.SongLength <= 0)
@@ -110,7 +109,6 @@ public override void _Ready()
         };
     }
 
-    //TODO: This will all change
     private void Begin()
     {
         CM.BeginTweens();
@@ -127,10 +125,13 @@ public override void _Process(double delta)
     {
         _focusedButton?.GrabFocus();
         TimeKeeper.CurrentTime = Audio.GetPlaybackPosition();
-        double realBeat = TimeKeeper.CurrentTime / (60 / (double)TimeKeeper.Bpm) % CM.BeatsPerLoop;
+        double realBeat =
+            TimeKeeper.CurrentTime / (60 / (double)TimeKeeper.Bpm) % CM.TrueBeatsPerLoop;
         CD.CheckMiss(realBeat);
         if (realBeat < _lastBeat)
+        {
             ChartLooped?.Invoke(this);
+        }
         _lastBeat = realBeat;
     }
     #endregion

scenes/BattleDirector/scripts/Conductor.cs

@@ -70,7 +70,7 @@ public override void _Ready()
         MM = new MidiMaestro(StageProducer.Config.CurSong.MIDILocation);
     }
 
-    public void Prep() //TODO: Streamline battle initialization
+    public void Prep()
     {
         _laneData = new NoteArrow[][]
         {
@@ -79,10 +79,10 @@ public void Prep() //TODO: Streamline battle initialization
             new NoteArrow[CM.BeatsPerLoop],
             new NoteArrow[CM.BeatsPerLoop],
         };
-        AddExampleNotes();
+        AddInitialNotes();
     }
 
-    private void AddExampleNotes()
+    private void AddInitialNotes()
     {
         foreach (ArrowType type in Enum.GetValues(typeof(ArrowType)))
         {

scenes/BattleDirector/scripts/NotePlacementBar.cs

@@ -192,7 +192,6 @@ public Note PlacedNote(BattleDirector BD)
         _currentBarValue -= (int)(_currentNoteInstance.CostModifier * MaxValue);
 
         UpdateNotePlacementBar(_currentBarValue);
-        //fullBarParticles.Emitting = false;
 
         Note placedNote = GetNote(Input.IsActionPressed("Secondary"));
         placedNote?.OnHit(BD, Timing.Okay); //Hardcode for now, eventually the note itself could have its default

scenes/ChartViewport/scripts/ChartManager.cs

@@ -95,7 +95,7 @@ public NoteArrow AddArrowToLane(
         Color colorOverride = default
     )
     {
-        var newNote = CreateNote(type, note, beat); //TODO: Notes on track have unqiue visuals
+        var newNote = CreateNote(type, note, beat);
         var loopArrow = CreateNote(type, note, beat, 1); //Create a dummy arrow for looping visuals
         if (colorOverride != default)
         {

scenes/ChartViewport/scripts/HitParticles.cs

@@ -11,12 +11,12 @@ public void Emit(int particleAmount)
 
         // Stop particles after a short delay using a Timer
         Timer timer = new Timer();
-        timer.WaitTime = 0.25f; // Stop emitting after 0.5 seconds
+        timer.WaitTime = 0.25f;
         timer.OneShot = true;
         timer.Timeout += () =>
         {
             Emitting = false;
-            timer.QueueFree(); // Clean up the timer
+            timer.QueueFree();
         };
 
         AddChild(timer);

scenes/ChartViewport/scripts/Loopable.cs

@@ -10,7 +10,6 @@ public partial class Loopable : Sprite2D
     [Export]
     public float LoopOffset = 700f; //px Pos to loop or do something at.
 
-    // Called every frame. 'delta' is the elapsed time since the previous frame.
     public override void _Process(double delta)
     {
         Vector2 newPos = Position;