player can place notes

notes that have been added by the player only appear when they are about 1/3rd of the way through the track

Author: cornerloan

scenes/BattleDirector/BattleDirector.cs

@@ -35,6 +35,7 @@ public struct SongData
     }
 
     private SongData _curSong;
+
     //Assume queue structure for notes in each lane.
     private readonly Note[][] _laneNotes = new Note[][]
     {
@@ -64,7 +65,8 @@ public override void _Process(double delta)
         double curBeat = TimeKeeper.CurrentTime / (60 / (double)_curSong.Bpm);
         for (int i = 0; i < _laneNotes.Length; i++)
         {
-            if (_laneNotes[i].Length <= 0) continue;
+            if (_laneNotes[i].Length <= 0)
+                continue;
             double beatDif = (curBeat - _laneNotes[i].First().Beat);
             if (beatDif > 1)
             {
@@ -105,9 +107,7 @@ private void OnNotePressed(NoteArrow.ArrowType type)
         CheckNoteTiming(type);
     }
 
-    private void OnNoteReleased(NoteArrow.ArrowType arrowType)
-    {
-    }
+    private void OnNoteReleased(NoteArrow.ArrowType arrowType) { }
 
     private void handleTiming(NoteArrow.ArrowType type, double beatDif)
     {
@@ -144,12 +144,28 @@ private void CheckNoteTiming(NoteArrow.ArrowType type)
     {
         double curBeat = TimeKeeper.CurrentTime / (60 / (double)_curSong.Bpm);
         if (_laneNotes[(int)type].Length == 0)
+        {
+            PlayerAddNote(type, (int)curBeat, 100); // 100 is temp, replace with current combo
             return;
+        }
         double beatDif = Math.Abs(curBeat - _laneNotes[(int)type].First().Beat);
         if (beatDif > 1)
+        {
+            PlayerAddNote(type, (int)curBeat, 100); // 100 is temp, replace with current combo
             return;
+        }
         GD.Print("Note Hit. Dif: " + beatDif);
         CM.HandleNote(type);
         handleTiming(type, beatDif);
     }
+
+    private void PlayerAddNote(NoteArrow.ArrowType type, int beat, int currentCombo)
+    {
+        // can also add some sort of keybind here to also have pressed
+        // in case the user just presses the note too early and spawns a note
+        if (currentCombo >= 100)
+        {
+            CM.CreateNote(type, beat);
+        }
+    }
 }

scenes/ChartViewport/ChartManager.cs

@@ -115,8 +115,12 @@ public void HandleNote(ArrowType type)
 
     public void OnNotePressed(ArrowType type)
     {
-        if (_currentArrows[(int)type].Length == 0)
-            return;
+        // removed this bit of code, since placement only worked on lines that already
+        // had arrows before the player added any. if needed we can add this back
+        // once we use charts that have arrows in all 4 rows from the beginning
+        //if (_currentArrows[(int)type].Length == 0)
+        //return;
+
         EmitSignal(nameof(NotePressed), (int)type);
     }