Node restructuring and make noteManager

Author: collectioncard

scenes/main.tscn

@@ -1,54 +1,64 @@
-[gd_scene load_steps=5 format=3 uid="uid://diq2m6va1x52k"]
+[gd_scene load_steps=6 format=3 uid="uid://diq2m6va1x52k"]
 
 [ext_resource type="Texture2D" uid="uid://bucvj4fquqpkr" path="res://scripts/noteSystem/assets/right-arrow.png" id="1_7tfja"]
-[ext_resource type="Script" path="res://scripts/NoteManager.cs" id="1_it331"]
+[ext_resource type="Script" path="res://scripts/Main.cs" id="1_it331"]
 [ext_resource type="Script" path="res://scripts/noteSystem/NoteChecker.cs" id="3_3bwsh"]
+[ext_resource type="Script" path="res://scripts/noteSystem/NoteManager.cs" id="3_hu33e"]
 [ext_resource type="Texture2D" uid="uid://b0tvsewgnf2x7" path="res://icon.svg" id="4_j3yyc"]
 
 [node name="Main" type="Node2D"]
 script = ExtResource("1_it331")
 
-[node name="arrowUp" type="Sprite2D" parent="."]
+[node name="ui" type="Node2D" parent="."]
+
+[node name="dividers" type="Node2D" parent="ui"]
+
+[node name="DivA" type="Sprite2D" parent="ui/dividers"]
+modulate = Color(0, 0, 0, 1)
+position = Vector2(320, 210)
+scale = Vector2(5.10938, 0.041)
+texture = ExtResource("4_j3yyc")
+
+[node name="DivB" type="Sprite2D" parent="ui/dividers"]
+modulate = Color(0, 0, 0, 1)
+position = Vector2(318, 255)
+scale = Vector2(5.10938, 0.041)
+texture = ExtResource("4_j3yyc")
+
+[node name="DivC" type="Sprite2D" parent="ui/dividers"]
+modulate = Color(0, 0, 0, 1)
+position = Vector2(317, 314)
+scale = Vector2(5.10938, 0.041)
+texture = ExtResource("4_j3yyc")
+
+[node name="noteManager" type="Node2D" parent="."]
+script = ExtResource("3_hu33e")
+
+[node name="noteCheckers" type="Node2D" parent="noteManager"]
+
+[node name="arrowUp" type="Sprite2D" parent="noteManager/noteCheckers"]
 position = Vector2(33, 179)
 rotation = -1.5708
 scale = Vector2(0.1, 0.1)
 texture = ExtResource("1_7tfja")
 script = ExtResource("3_3bwsh")
 
-[node name="arrowLeft" type="Sprite2D" parent="."]
+[node name="arrowLeft" type="Sprite2D" parent="noteManager/noteCheckers"]
 position = Vector2(33, 233)
 rotation = 3.14159
 scale = Vector2(0.1, 0.1)
 texture = ExtResource("1_7tfja")
 script = ExtResource("3_3bwsh")
 
-[node name="arrowDown" type="Sprite2D" parent="."]
+[node name="arrowDown" type="Sprite2D" parent="noteManager/noteCheckers"]
 position = Vector2(33, 285)
 rotation = 1.5708
 scale = Vector2(0.1, 0.1)
 texture = ExtResource("1_7tfja")
 script = ExtResource("3_3bwsh")
 
-[node name="arrowRight" type="Sprite2D" parent="."]
+[node name="arrowRight" type="Sprite2D" parent="noteManager/noteCheckers"]
 position = Vector2(33, 336)
 scale = Vector2(0.1, 0.1)
 texture = ExtResource("1_7tfja")
 script = ExtResource("3_3bwsh")
-
-[node name="DivA" type="Sprite2D" parent="."]
-modulate = Color(0, 0, 0, 1)
-position = Vector2(320, 210)
-scale = Vector2(5.10938, 0.041)
-texture = ExtResource("4_j3yyc")
-
-[node name="DivB" type="Sprite2D" parent="."]
-modulate = Color(0, 0, 0, 1)
-position = Vector2(318, 255)
-scale = Vector2(5.10938, 0.041)
-texture = ExtResource("4_j3yyc")
-
-[node name="DivC" type="Sprite2D" parent="."]
-modulate = Color(0, 0, 0, 1)
-position = Vector2(317, 314)
-scale = Vector2(5.10938, 0.041)
-texture = ExtResource("4_j3yyc")

scripts/Main.cs

@@ -0,0 +1,24 @@
+using System;
+using Godot;
+using static NoteManager;
+
+public partial class Main : Node2D
+{
+    private NoteManager _noteManager;
+
+    public override void _Ready()
+    {
+        _noteManager = GetNode<NoteManager>("noteManager");
+        _noteManager.CreateNote(ArrowType.Down);
+    }
+
+    public override void _Process(double delta)
+    {
+        //have a tiny chance of spanning a note in a row every frame. For testing purposes.
+        if (GD.Randf() >= 0.02f)
+            return;
+        var randomLane = (ArrowType)
+            GD.RandRange(0, ArrowType.GetValues(typeof(ArrowType)).Length - 1);
+        _noteManager.CreateNote(randomLane);
+    }
+}

scripts/NoteManager.cs scripts/noteSystem/NoteManager.csscripts/NoteManager.cs renamed to scripts/noteSystem/NoteManager.cs

@@ -30,7 +30,7 @@ private void InitializeArrowCheckers()
                 {
                     color = Colors.Green,
                     key = "arrowUp",
-                    node = GetNode<NoteChecker>("arrowUp"),
+                    node = GetNode<NoteChecker>("noteCheckers/arrowUp"),
                 }
             },
             {
@@ -39,7 +39,7 @@ private void InitializeArrowCheckers()
                 {
                     color = Colors.Aqua,
                     key = "arrowDown",
-                    node = GetNode<NoteChecker>("arrowDown"),
+                    node = GetNode<NoteChecker>("noteCheckers/arrowDown"),
                 }
             },
             {
@@ -48,7 +48,7 @@ private void InitializeArrowCheckers()
                 {
                     color = Colors.HotPink,
                     key = "arrowLeft",
-                    node = GetNode<NoteChecker>("arrowLeft"),
+                    node = GetNode<NoteChecker>("noteCheckers/arrowLeft"),
                 }
             },
             {
@@ -57,7 +57,7 @@ private void InitializeArrowCheckers()
                 {
                     color = Colors.Red,
                     key = "arrowRight",
-                    node = GetNode<NoteChecker>("arrowRight"),
+                    node = GetNode<NoteChecker>("noteCheckers/arrowRight"),
                 }
             },
         };
@@ -72,26 +72,9 @@ private void InitializeArrowCheckers()
     public override void _Ready()
     {
         InitializeArrowCheckers();
-
-        CreateNote(ArrowType.Up);
-        CreateNote(ArrowType.Down);
-        CreateNote(ArrowType.Left);
-        CreateNote(ArrowType.Right);
     }
 
     public override void _Process(double delta)
-    {
-        HandleInput();
-
-        //have a 20% chance of creating a note in a random lane
-        if (GD.Randf() >= 0.02f)
-            return;
-        var randomLane = (ArrowType)
-            GD.RandRange(0, ArrowType.GetValues(typeof(ArrowType)).Length - 1);
-        CreateNote(randomLane);
-    }
-
-    private void HandleInput()
     {
         foreach (var arrow in _arrows)
         {
@@ -106,7 +89,7 @@ private void HandleInput()
         }
     }
 
-    private void CreateNote(ArrowType arrow)
+    public void CreateNote(ArrowType arrow)
     {
         CreateNote(_arrows[arrow]);
     }

scripts/noteSystem/note.tscn

@@ -1,4 +1,4 @@
-[gd_scene load_steps=3 format=3 uid="uid://oax3qu72soro"]
+[gd_scene load_steps=3 format=3 uid="uid://ck3bfqy30rjbq"]
 
 [ext_resource type="Texture2D" uid="uid://bucvj4fquqpkr" path="res://scripts/noteSystem/assets/right-arrow.png" id="1_kubiy"]
 [ext_resource type="Script" path="res://scripts/noteSystem/Note.cs" id="2_gpd2w"]