Skip to content

Commit d8bb0c5

Browse files
committed
Simplify arrow creation
1 parent 5585c4b commit d8bb0c5

1 file changed

Lines changed: 6 additions & 12 deletions

File tree

scenes/ChartViewport/ChartManager.cs

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ private void InitBackgrounds()
6565
}
6666
}
6767

68-
//TODO: Rework these?
6968
public NoteArrow AddArrowToLane(Note note, int noteIdx)
7069
{
7170
var newNote = CreateNote(note.Type, note.Beat);
@@ -75,18 +74,13 @@ public NoteArrow AddArrowToLane(Note note, int noteIdx)
7574
}
7675

7776
private NoteArrow CreateNote(ArrowType arrow, int beat = 0)
78-
{
79-
var newNote = CreateNote(IH.Arrows[(int)arrow]);
80-
newNote.Bounds = (float)((double)beat / BeatsPerLoop * (ChartLength / 2));
81-
return newNote;
82-
}
83-
84-
private NoteArrow CreateNote(InputHandler.ArrowData arrowData)
8577
{
8678
var noteScene = ResourceLoader.Load<PackedScene>("res://scenes/NoteManager/note.tscn");
87-
NoteArrow note = noteScene.Instantiate<NoteArrow>();
88-
note.Init(arrowData);
89-
ChartLoopables.AddChild(note);
90-
return note;
79+
NoteArrow newArrow = noteScene.Instantiate<NoteArrow>();
80+
newArrow.Init(IH.Arrows[(int)arrow]);
81+
82+
ChartLoopables.AddChild(newArrow);
83+
newArrow.Bounds = (float)((double)beat / BeatsPerLoop * (ChartLength / 2));
84+
return newArrow;
9185
}
9286
}

0 commit comments

Comments
 (0)