Minor Refinements

Removed Description on Note class to build translation key.
Made description for enemy effect an optional parameter.
Adjusted translations for accuracy.
Removed effect description from Strawman to not compete screen space with arrow input guides.
Better set up description box in controls.

Author: LifeHckr

Classes/Notes/Note.cs

@@ -18,17 +18,14 @@ public partial class Note : Resource, IDisplayable
     public const double TimingMax = 0.5d; //The max range for a note to be timed is its beat +/- this const
     public Texture2D Texture { get; set; }
 
-    public string Description;
-
     public Note(
         int id,
         string name,
         Texture2D texture = null,
         int baseVal = 1,
         Action<BattleDirector, Note, Timing> noteEffect = null,
         float costModifier = 1.0f,
-        Targetting targetType = Targetting.First,
-        string description = null
+        Targetting targetType = Targetting.First
     )
     {
         Id = id;
@@ -38,7 +35,6 @@ public Note(
         Texture = texture;
         CostModifier = costModifier;
         TargetType = targetType;
-        Description = description;
     }
 
     public void OnHit(BattleDirector BD, Timing timing)

Globals/Scribe.cs

@@ -150,8 +150,7 @@ public partial class Scribe : Node
                 if (timing == Timing.Perfect)
                     dmg = 0;
                 director.DealDamage(Targetting.Player, dmg, note.Owner);
-            },
-            description: "GWS_NOTE_DESCRIPTION"
+            }
         ),
         new Note(
             11,
@@ -189,8 +188,7 @@ public partial class Scribe : Node
             {
                 int amt = Math.Max((3 - (int)timing) * note.GetBaseVal(), 0);
                 director.AddStatus(Targetting.All, StatusEffect.Block, amt);
-            },
-            description: "PARASIFLY_NOTE_DESCRIPTION"
+            }
         ),
         new Note(
             14,
@@ -205,8 +203,7 @@ public partial class Scribe : Node
                     note.Owner.Heal((3 - (int)timing));
             },
             default,
-            Targetting.Player,
-            "BOSSBLOOD_NOTE_DESCRIPTION"
+            Targetting.Player
         ),
         new Note(
             15,
@@ -219,8 +216,7 @@ public partial class Scribe : Node
                     return;
                 int amt = Math.Max((3 - (int)timing) * note.GetBaseVal(), 1);
                 director.AddStatus(Targetting.Player, StatusEffect.Poison, amt);
-            },
-            description: "SPIDER_NOTE_DESCRIPTION"
+            }
         ),
         new Note(
             16,
@@ -233,8 +229,7 @@ public partial class Scribe : Node
                 if (timing == Timing.Perfect)
                     dmg = 0;
                 director.DealDamage(Targetting.Player, dmg, note.Owner);
-            },
-            description: "LWS_NOTE_DESCRIPTION"
+            }
         ),
         new Note(
             17,
@@ -247,8 +242,7 @@ public partial class Scribe : Node
                     return;
                 int amt = Math.Max((3 - (int)timing) * note.GetBaseVal(), 1);
                 director.AddStatus(Targetting.Player, StatusEffect.Poison, amt);
-            },
-            description: "MUSHROOM_NOTE_DESCRIPTION"
+            }
         ),
         new Note(
             18,

Globals/Translations/Translations.csv

@@ -207,21 +207,21 @@ CREDITS_ADDITIONAL_HELP,Additional Help,额外协助
 CREDITS_OTHER_PLAYTESTERS,All our other playtesters,以及所有其他测试玩家
 CREDITS_SPECIAL_THANKS,Special Thanks,特别鸣谢
 CREDITS_THANKS_PLAYERS,And to you the player!,以及屏幕前的你！
-BOSSBLOOD_EFFECT1,"Heal {0} and convert a basic note into a Blood note","每循环治疗 {0} 点生命，并将一个普通音符转化为血之音符"
-CYBERFOX_EFFECT1,Gains one dodge,获得一次闪避
-EFFIGY_EFFECT1,Only takes 1 damage at a time,每次只受到1点伤害
-EFFIGY_EFFECT2,Sets player's health to 1 if defeated,被击败时将玩家的生命值设为1
-HOLOGRAEME_EFFECT1,Player only plays every other loop,玩家每隔一轮行动一次
-HOLOGRAEME_EFFECT2,Holograeme only has 1 health,Holograeme 只有1点生命值
-KEYTHULU_EFFECT1,"Keythulu will kill the player after {0} loops","Keythulu 会在 {0} 个循环后杀死玩家"
-LWS_EFFECT1,Converts a basic note into a Lesser Wolf Spirit note,将一个普通音符转化为小狼灵音符
-PARASIFLY_EFFECT1,Parasifly gains block the first time fatal damage is dealt,Parasifly 在首次受到致命伤害时获得格挡
-STRAWMAN_EFFECT1,Player cannot take fatal damage,玩家不会受到致命伤害
-GWS_EFFECT1,Adds Greater Wolf Spirit notes after the first loop,第一轮后添加大狼灵音符
-TURTLE_EFFECT1,Gains one block and removes some of player's charge,获得一层格挡并移除玩家的一些能量
-GWS_NOTE_DESCRIPTION,"Deals double damage plus the number of loops","造成双倍双倍伤害，并附加当前循环数值"
-PARASIFLY_NOTE_DESCRIPTION,Parasifly gains block based on timing,Parasifly 根据时机获得格挡
-BOSSBLOOD_NOTE_DESCRIPTION,Blood heals based on timing,血液根据时机恢复生命
-SPIDER_NOTE_DESCRIPTION,Player gets poisoned based on timing,玩家根据时机中毒
-LWS_NOTE_DESCRIPTION,Deals damage plus half the number of loops,造成伤害并额外附加一半的循环次数
-MUSHROOM_NOTE_DESCRIPTION,Player gets poisoned based on timing,玩家根据时机中毒
+BOSSBLOOD_EFFECT1,"Heal and convert a basic note into a Blood note.","每循环治疗 点生命，并将一个普通音符转化为血之音符。"
+CYBERFOX_EFFECT1,Gains one dodge.,获得一次闪避。
+EFFIGY_EFFECT1,Only takes 1 damage at a time.,每次只受到1点伤害。
+EFFIGY_EFFECT2,Sets player's health to 1 if defeated.,被击败时将玩家的生命值设为1。
+HOLOGRAEME_EFFECT1,Player only plays every other loop.,玩家每隔一轮行动一次。
+HOLOGRAEME_EFFECT2,"Holograeme only has 1 health, and is immune to relic damage.","全息格莱姆仅有1点生命值，且免疫遗物伤害。"
+KEYTHULU_EFFECT1,"Every loop mindcrush ticks down by one, when it reaches zero, the player is defeated.","每次循环，心灵碾压计数会减1。当计数归零时，玩家即被击败。"
+LWS_EFFECT1,Converts an empty note into a Lesser Wolf Snake note.,将一个基础音符转化为次级狼蛇音符。
+PARASIFLY_EFFECT1,All enemies gains block the first time fatal damage is dealt.,首次受到致命伤害时，所有敌人获得格挡。
+STRAWMAN_EFFECT1,Player cannot take fatal damage.,玩家不会受到致命伤害。
+GWS_EFFECT1,Adds Greater Wolf Snake notes after the first loop.,首次循环后，添加高级狼蛇音符。
+TURTLE_EFFECT1,Gains one block and drains some of player's charge to heal.,获得一层格挡，并消耗玩家部分充能以进行治疗。
+GWS_NOTE_DESCRIPTION,"If timed badly, deals high damage to the player. Damage increases each loop.","若时机不佳，则对玩家造成高额伤害，且伤害随每次循环递增。"
+PARASIFLY_NOTE_DESCRIPTION,Parasifly gains block if timed badly.,若时机不佳，寄生蝇获得格挡。
+BOSSBLOOD_NOTE_DESCRIPTION,Boss Blood heals if timed badly.,若时机不佳，首领之血会进行治疗。
+SPIDER_NOTE_DESCRIPTION,Player gets poisoned if timed badly.,若时机不佳，玩家会中毒。
+LWS_NOTE_DESCRIPTION,"If timed badly, deals damage to the player. Damage increases each loop.","若时机不佳，则对玩家造成伤害，且伤害随每次循环递增。"
+MUSHROOM_NOTE_DESCRIPTION,Player gets poisoned if timed badly.,若时机不佳，玩家会中毒。

Scenes/BattleDirector/Assets/BattleEndSymbol.png

@@ -102,9 +102,9 @@ offset_bottom = 360.0
 texture = ExtResource("7_klvil")
 
 [node name="StartButton" type="Button" parent="."]
-offset_left = 185.0
+offset_left = 190.0
 offset_top = 200.0
-offset_right = 445.0
+offset_right = 450.0
 offset_bottom = 248.0
 theme = ExtResource("8_62qim")
 text = "BATTLE_ROOM_BEGIN_BUTTON"
@@ -146,8 +146,12 @@ theme_override_font_sizes/font_size = 64
 text = "5"
 
 [node name="EnemyDescriptions" parent="." instance=ExtResource("11_gbbxr")]
-z_index = 1
-offset_left = 170.0
-offset_top = 248.0
-offset_right = 170.0
-offset_bottom = 248.0
+anchors_preset = 0
+anchor_right = 0.0
+anchor_bottom = 0.0
+offset_left = 320.0
+offset_top = 183.0
+offset_right = 320.0
+offset_bottom = 183.0
+grow_horizontal = 1
+grow_vertical = 1

Scenes/BattleDirector/Assets/LoopSymbol.png

@@ -10,17 +10,41 @@ anchor_right = 1.0
 anchor_bottom = 1.0
 grow_horizontal = 2
 grow_vertical = 2
+mouse_filter = 2
 script = ExtResource("1_r3tcc")
-DescriptionsContainer = NodePath("VBoxContainer")
+DescriptionsContainer = NodePath("Center/MarginContainer/MarginContainer/VBoxContainer")
 
-[node name="UiCenterFrame" type="Sprite2D" parent="."]
-scale = Vector2(3.02083, 1.88462)
+[node name="Center" type="CenterContainer" parent="."]
+layout_mode = 1
+anchors_preset = 15
+anchor_right = 1.0
+anchor_bottom = 1.0
+grow_horizontal = 2
+grow_vertical = 2
+mouse_filter = 2
+
+[node name="MarginContainer" type="MarginContainer" parent="Center"]
+layout_mode = 2
+mouse_filter = 2
+theme_override_constants/margin_top = 230
+
+[node name="UiCenterFrame" type="NinePatchRect" parent="Center/MarginContainer"]
+custom_minimum_size = Vector2(280, 80)
+layout_mode = 2
 texture = ExtResource("2_mg2uj")
-centered = false
+patch_margin_left = 12
+patch_margin_top = 12
+patch_margin_right = 12
+patch_margin_bottom = 12
+
+[node name="MarginContainer" type="MarginContainer" parent="Center/MarginContainer"]
+layout_mode = 2
+mouse_filter = 2
+theme_override_constants/margin_left = 8
+theme_override_constants/margin_top = 6
+theme_override_constants/margin_right = 8
+theme_override_constants/margin_bottom = 6
 
-[node name="VBoxContainer" type="VBoxContainer" parent="."]
-layout_mode = 0
-offset_left = 15.0
-offset_top = 6.0
-offset_right = 275.0
-offset_bottom = 91.0
+[node name="VBoxContainer" type="VBoxContainer" parent="Center/MarginContainer/MarginContainer"]
+layout_mode = 2
+mouse_filter = 2

Scenes/BattleDirector/BattleScene.tscn

@@ -35,7 +35,7 @@ public partial class BattleDirector : Node2D
     private AudioStreamPlayer Audio;
 
     [Export]
-    private EnemyDescriptions Descriptions;
+    public EnemyDescriptions Descriptions;
 
     [Export]
     public Button FocusedButton; //Initial start button

Scenes/BattleDirector/EnemyDescriptions.tscn

@@ -17,24 +17,24 @@ public partial class EnemyDescriptions : Control
         "res://Scenes/BattleDirector/Assets/BattleEndSymbol.png";
 
     private bool _isVisible = false;
+    private const string TranslationKeySuffix = "_NOTE_DESCRIPTION";
 
     public void Setup(EnemyPuppet enemy)
     {
-        if (enemy.InitialNote != (0, 0))
+        if (enemy.InitialNote.Amount > 0)
         {
-            string desc = Scribe.NoteDictionary[enemy.InitialNote.NoteId].Description;
+            string desc = NoteDescBuilder(Scribe.NoteDictionary[enemy.InitialNote.NoteId].Name);
             AddDescriptionRow(Scribe.NoteDictionary[enemy.InitialNote.NoteId].Texture, desc);
             _isVisible = true;
         }
 
         foreach (var effect in enemy.GetBattleEvents())
         {
-            if (effect.Description != null)
-            {
-                Texture2D icon = GetTriggerIcon(effect.GetTrigger());
-                AddDescriptionRow(icon, effect.Description);
-                _isVisible = true;
-            }
+            if (effect.Description == null)
+                continue;
+            Texture2D icon = GetTriggerIcon(effect.GetTrigger());
+            AddDescriptionRow(icon, effect.Description);
+            _isVisible = true;
         }
 
         Visible = _isVisible;
@@ -46,17 +46,23 @@ private void AddDescriptionRow(Texture2D iconTexture, string text)
 
         TextureRect icon = new TextureRect();
         icon.Texture = iconTexture;
+        icon.StretchMode = TextureRect.StretchModeEnum.Keep;
 
         Label desc = new Label();
         desc.Text = text;
-        desc.SizeFlagsHorizontal = Control.SizeFlags.ExpandFill;
+        desc.SizeFlagsHorizontal = SizeFlags.ExpandFill;
         desc.AutowrapMode = TextServer.AutowrapMode.WordSmart;
 
         hbox.AddChild(icon);
         hbox.AddChild(desc);
         DescriptionsContainer.AddChild(hbox);
     }
 
+    private string NoteDescBuilder(string noteName)
+    {
+        return noteName.ToUpper() + TranslationKeySuffix;
+    }
+
     private Texture2D GetTriggerIcon(BattleEffectTrigger trigger)
     {
         //TODO: add more as we get more enemy effect triggers

Scenes/BattleDirector/Scripts/BattleDirector.cs

@@ -341,6 +341,7 @@ public void OnPlaceDialogue4()
     public void BossDialogue()
     {
         _dialogueBox.Visible = true;
+        _currentDirector.Descriptions.Visible = false;
         GetTree().SetPause(true);
         _currentDirector.FocusedButton.Visible = false;
         _dialogueLabel.Text = Tr("TUTORIAL_BOSS");
@@ -355,6 +356,7 @@ public void BossDialogueReady()
         GetTree().SetPause(false);
         _currentDirector.FocusedButton.Visible = true;
         _currentDirector.FocusedButton.GrabFocus();
+        _currentDirector.Descriptions.Visible = true;
     }
     #endregion
 }