fix: address code review feedback (POST idempotency, SDK default, stream cancel safety)

Co-Authored-By: Chris K <ckorhonen@gmail.com>

Author: devin-ai-integration[bot]

src/client.ts

@@ -2,11 +2,12 @@ import type { OpenSeaClientConfig } from "./types/index.js"
 
 const DEFAULT_BASE_URL = "https://api.opensea.io"
 const DEFAULT_TIMEOUT_MS = 30_000
-const DEFAULT_MAX_RETRIES = 3
+const DEFAULT_MAX_RETRIES = 0
 const DEFAULT_RETRY_BASE_DELAY_MS = 1_000
 
-function isRetryableStatus(status: number): boolean {
-  return status === 429 || status >= 500
+function isRetryableStatus(status: number, method: string): boolean {
+  if (status === 429) return true
+  return status >= 500 && method === "GET"
 }
 
 function parseRetryAfter(header: string | null): number | undefined {
@@ -135,7 +136,11 @@ export class OpenSeaClient {
         return response
       }
 
-      if (attempt < this.maxRetries && isRetryableStatus(response.status)) {
+      const method = init.method ?? "GET"
+      if (
+        attempt < this.maxRetries &&
+        isRetryableStatus(response.status, method)
+      ) {
         const retryAfterMs = parseRetryAfter(
           response.headers.get("Retry-After"),
         )
@@ -149,7 +154,11 @@ export class OpenSeaClient {
           )
         }
 
-        await response.body?.cancel()
+        try {
+          await response.body?.cancel()
+        } catch {
+          // Stream may already be disturbed
+        }
         await sleep(delayMs)
         continue
       }

test/client.test.ts

@@ -264,14 +264,14 @@ describe("OpenSeaClient", () => {
       expect(fetch).toHaveBeenCalledTimes(2)
     })
 
-    it("retries post requests", async () => {
+    it("retries post requests on 429", async () => {
       const retryClient = new OpenSeaClient({
         apiKey: "test-key",
         maxRetries: 3,
         retryBaseDelay: 100,
       })
       vi.spyOn(globalThis, "fetch")
-        .mockResolvedValueOnce(new Response("Server Error", { status: 503 }))
+        .mockResolvedValueOnce(new Response("Rate limited", { status: 429 }))
         .mockResolvedValueOnce(
           new Response(JSON.stringify({ status: "ok" }), {
             status: 200,
@@ -286,6 +286,22 @@ describe("OpenSeaClient", () => {
       expect(fetch).toHaveBeenCalledTimes(2)
     })
 
+    it("does not retry post requests on 5xx", async () => {
+      const retryClient = new OpenSeaClient({
+        apiKey: "test-key",
+        maxRetries: 3,
+        retryBaseDelay: 100,
+      })
+      vi.spyOn(globalThis, "fetch").mockResolvedValue(
+        new Response("Server Error", { status: 503 }),
+      )
+
+      await expect(retryClient.post("/api/v2/refresh")).rejects.toThrow(
+        OpenSeaAPIError,
+      )
+      expect(fetch).toHaveBeenCalledTimes(1)
+    })
+
     it("logs retries when verbose is enabled", async () => {
       const verboseRetryClient = new OpenSeaClient({
         apiKey: "test-key",