Skip to content

Commit 1c8994c

Browse files
LKaemmerlingmtk3d
authored andcommitted
Merge branch 'main' into feature/add-predis-support
2 parents b984afa + d50d083 commit 1c8994c

6 files changed

Lines changed: 12 additions & 11 deletions

File tree

.github/workflows/blackbox.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,10 @@ jobs:
2222
- name: Setup PHP
2323
uses: shivammathur/setup-php@v2
2424
with:
25-
php-version: 8.4
25+
php-version: 8.2
2626
coverage: none
2727
- name: Login to Docker Hub
28+
continue-on-error: true
2829
uses: docker/login-action@v3
2930
with:
3031
username: ${{ secrets.DOCKERHUB_USERNAME }}
@@ -40,6 +41,3 @@ jobs:
4041
run: docker compose run phpunit env ADAPTER=apcng vendor/bin/phpunit tests/Test/
4142
- name: Run Blackbox with Redis
4243
run: docker compose run phpunit env ADAPTER=redis vendor/bin/phpunit tests/Test/
43-
44-
45-

.github/workflows/checks.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ jobs:
1717
path: ~/.composer/cache/files
1818
key: dependencies-code-checks
1919
- name: Login to Docker Hub
20+
continue-on-error: true
2021
uses: docker/login-action@v3
2122
with:
2223
username: ${{ secrets.DOCKERHUB_USERNAME }}

.github/workflows/tests.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ jobs:
66
test:
77
runs-on: ubuntu-latest
88
strategy:
9-
fail-fast: true
9+
fail-fast: false
1010
matrix:
11-
php: [ 8.1, 8.2, 8.3, 8.4 ]
12-
redis-version: [ 5, 6, 7 ]
11+
php: [ 8.2, 8.3, 8.4, 8.5 ]
12+
redis-version: [ 5, 6, 7, 8 ]
1313

1414
name: P${{ matrix.php }} - Redis ${{ matrix.redis-version }}
1515

@@ -49,6 +49,7 @@ jobs:
4949
path: ~/.composer/cache/files
5050
key: dependencies-php-${{ matrix.php }}-composer-${{ hashFiles('composer.json') }}
5151
- name: Login to Docker Hub
52+
continue-on-error: true
5253
uses: docker/login-action@v3
5354
with:
5455
username: ${{ secrets.DOCKERHUB_USERNAME }}

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# A prometheus client library written in PHP
22

33
![Tests](https://github.com/promphp/prometheus_client_php/workflows/Tests/badge.svg)
4+
[![Slack](https://img.shields.io/badge/Slack-join%20chat-brightgreen)](https://join.slack.com/t/promphp/shared_invite/zt-iqbocinr-R809BvkEhjuC9W6RRoOofA)
45

56
This library uses Redis or APCu to do the client side aggregation.
67
If using Redis, we recommend running a local Redis instance next to your PHP workers.
@@ -135,7 +136,7 @@ composer require promphp/prometheus_push_gateway_php
135136

136137
### Dependencies
137138

138-
* PHP ^7.2 | ^8.0
139+
* PHP ^8.2 (only [supported PHP versions](https://www.php.net/supported-versions.php) are supported)
139140
* PHP Redis extension
140141
* PHP APCu extension
141142
* [Composer](https://getcomposer.org/doc/00-intro.md#installation-linux-unix-osx)

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"lkaemmerling/prometheus_client_php": "*"
1616
},
1717
"require": {
18-
"php": "^7.4|^8.0",
18+
"php": "^8.2",
1919
"ext-json": "*"
2020
},
2121
"require-dev": {
@@ -35,7 +35,7 @@
3535
"ext-apc": "Required if using APCu.",
3636
"ext-pdo": "Required if using PDO.",
3737
"promphp/prometheus_push_gateway_php": "An easy client for using Prometheus PushGateway.",
38-
"symfony/polyfill-apcu": "Required if you use APCu on PHP8.0+"
38+
"symfony/polyfill-apcu": "Required if you use APCu."
3939
},
4040
"autoload": {
4141
"psr-4": {

src/Prometheus/Storage/APCng.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -825,7 +825,7 @@ private function decrementKeyWithValue(string $key, $val): void
825825
*/
826826
private function convertToIncrementalInteger($val): int
827827
{
828-
return intval($val * $this->precisionMultiplier);
828+
return @intval($val * $this->precisionMultiplier);
829829
}
830830

831831
private function convertIncrementalIntegerToFloat(int $val): float

0 commit comments

Comments
 (0)