Skip to content

Commit cd60a02

Browse files
simPodLKaemmerling
andauthored
Add PHP 8.5 to CI test matrix (#198)
- Disable fail-fast to see results for all PHP versions - Fix APCng overflow warning on PHP 8.5 when casting out-of-range float to int in convertToIncrementalInteger() Signed-off-by: Simon Podlipsky <simon@podlipsky.net> Co-authored-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>
1 parent f23fc80 commit cd60a02

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ jobs:
66
test:
77
runs-on: ubuntu-latest
88
strategy:
9-
fail-fast: true
9+
fail-fast: false
1010
matrix:
11-
php: [ 8.1, 8.2, 8.3, 8.4 ]
11+
php: [ 8.1, 8.2, 8.3, 8.4, 8.5 ]
1212
redis-version: [ 5, 6, 7, 8 ]
1313

1414
name: P${{ matrix.php }} - Redis ${{ matrix.redis-version }}

src/Prometheus/Storage/APCng.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -825,7 +825,7 @@ private function decrementKeyWithValue(string $key, $val): void
825825
*/
826826
private function convertToIncrementalInteger($val): int
827827
{
828-
return intval($val * $this->precisionMultiplier);
828+
return @intval($val * $this->precisionMultiplier);
829829
}
830830

831831
private function convertIncrementalIntegerToFloat(int $val): float

0 commit comments

Comments
 (0)