Skip to content

Commit d52fac3

Browse files
simPodLKaemmerling
andauthored
CI: Allow Docker Hub login to fail gracefully for fork PRs (#197)
Fork PRs don't have access to repository secrets, causing the login step to fail and blocking the entire workflow. Adding continue-on-error lets forks run CI unauthenticated while upstream still benefits from authenticated pulls. Co-authored-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>
1 parent 428e876 commit d52fac3

3 files changed

Lines changed: 3 additions & 0 deletions

File tree

.github/workflows/blackbox.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ jobs:
2525
php-version: 8.4
2626
coverage: none
2727
- name: Login to Docker Hub
28+
continue-on-error: true
2829
uses: docker/login-action@v3
2930
with:
3031
username: ${{ secrets.DOCKERHUB_USERNAME }}

.github/workflows/checks.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ jobs:
1717
path: ~/.composer/cache/files
1818
key: dependencies-code-checks
1919
- name: Login to Docker Hub
20+
continue-on-error: true
2021
uses: docker/login-action@v3
2122
with:
2223
username: ${{ secrets.DOCKERHUB_USERNAME }}

.github/workflows/tests.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ jobs:
4949
path: ~/.composer/cache/files
5050
key: dependencies-php-${{ matrix.php }}-composer-${{ hashFiles('composer.json') }}
5151
- name: Login to Docker Hub
52+
continue-on-error: true
5253
uses: docker/login-action@v3
5354
with:
5455
username: ${{ secrets.DOCKERHUB_USERNAME }}

0 commit comments

Comments
 (0)