RedisCluster support

[mvhirsch]

I'm currently working on RedisCluster support but do lack knowledge about keyspace and slots. Looks like there was once an approach (see #112), but at the time of writing there is no update.

I managed to connect my RedisCluster, but run into errors like this:

Warning: RedisCluster::eval(): All keys do not map to the same slot 

I read Redis Clustering best practices with keys but to be honest I'm clueless (or keyless? 😂 ). Any help is appreciated. I'd like to get this running soon, as one of my projects needs it.

[mvhirsch]

I see there is also an open request for Redis Sentinel #95 and a pending PR for Predis #127.

I'd like to introduce a RedisAdapter that's capable to work with all of them, by abstracting and hiding away the special use-cases (like in RedisCluster or Predis). Using a method like the one symfony/cache uses, it would be easy to connect to any redis instance supported by them using a simple DSN.

https://github.com/symfony/symfony/blob/02c1e3c5c31dfc7f7f2b13515b060639cfac838a/src/Symfony/Component/Cache/Traits/RedisTrait.php#L87

Of course, that requires a bigger rewrite of the current Redis and I'm still not sure what role RedisNg is (see #152).

WDYT?

[LKaemmerling]

Sounds great!

[Sfonxs]

@mvhirsch Did you end up getting something working?

[mvhirsch]

I never finished my work and it's unlikely I'll do in foreseeable future. Feel free to take over @Sfonxs !

[Sfonxs]

I never finished my work and it's unlikely I'll do in foreseeable future. Feel free to take over @Sfonxs !

For now I have added a workaround to be able to continue my testing:

            $redis = Redis::fromExistingConnection(...);
            $reflection = new ReflectionClass(Redis::class);
            $property = $reflection->getProperty('prefix');
            $property->setValue($redis, '{PROMETHEUS}_');

It's not a good solution since all the load will go to a single redis node (and it's using reflection), but at least it works...

[MihaiCraciun88]

I never finished my work and it's unlikely I'll do in foreseeable future. Feel free to take over @Sfonxs !

For now I have added a workaround to be able to continue my testing:

        $redis = Redis::fromExistingConnection(...);
        $reflection = new ReflectionClass(Redis::class);
        $property = $reflection->getProperty('prefix');
        $property->setValue($redis, '{PROMETHEUS}_');

It's not a good solution since all the load will go to a single redis node (and it's using reflection), but at least it works...

you can use Redis::setPrefix('{PROMETHEUS}_')

also I had to change the function to:

    public static function fromExistingConnection(\Redis|\RedisCluster|\RedisSentinel $redis): self
    {
        if (!$redis->ping('1')) {
            throw new StorageException('Connection to Redis server not established');
        }

        $self = new self();
        $self->connectionInitialized = true;
        $self->redis = $redis;

        return $self;
    }