Merge pull request #22 from konard/issue-19-793570d5e6b2

refactor(app): remove unused ViteBabelState and extract plugin name constant

Author: skulidropek

packages/app/babel.cjs

@@ -22,6 +22,7 @@
 
 const path = require("node:path")
 
+const babelPluginName = "component-path-babel-tagger"
 const componentPathAttributeName = "data-path"
 const jsxFilePattern = /\.(tsx|jsx)(\?.*)?$/u
 
@@ -37,7 +38,7 @@ const attrExists = (node, attrName, t) =>
 
 module.exports = function componentTaggerBabelPlugin({ types: t }) {
   return {
-    name: "component-path-babel-tagger",
+    name: babelPluginName,
     visitor: {
       JSXOpeningElement(nodePath, state) {
         const { node } = nodePath

packages/app/src/core/component-path.ts

@@ -1,5 +1,17 @@
 const jsxFilePattern = /\.(tsx|jsx)(\?.*)?$/u
 
+// CHANGE: define canonical Babel plugin name for component path tagging.
+// WHY: eliminate magic string duplication across plugin implementations.
+// QUOTE(ТЗ): "Вынести строки имён плагинов в константы (чтобы не дублировать \"component-path-babel-tagger\")."
+// REF: issue-19
+// SOURCE: n/a
+// FORMAT THEOREM: forall p in PluginName: p = "component-path-babel-tagger"
+// PURITY: CORE
+// EFFECT: n/a
+// INVARIANT: plugin name remains stable across all implementations
+// COMPLEXITY: O(1)/O(1)
+export const babelPluginName = "component-path-babel-tagger"
+
 /**
  * Normalizes a module ID by stripping query parameters.
  *

packages/app/src/shell/babel-plugin.ts

@@ -1,6 +1,6 @@
 import { type PluginObj, types as t } from "@babel/core"
 
-import { componentPathAttributeName, isJsxFile } from "../core/component-path.js"
+import { babelPluginName, componentPathAttributeName, isJsxFile } from "../core/component-path.js"
 import { createJsxTaggerVisitor, type JsxTaggerContext } from "../core/jsx-tagger.js"
 import { computeRelativePath } from "../core/path-service.js"
 
@@ -112,7 +112,7 @@ const getContextFromState = (state: BabelState): JsxTaggerContext | null => {
 // INVARIANT: each JSX opening element has at most one path attribute
 // COMPLEXITY: O(n)/O(1)
 export const componentTaggerBabelPlugin = (): PluginObj<BabelState> => ({
-  name: "component-path-babel-tagger",
+  name: babelPluginName,
   visitor: createJsxTaggerVisitor<BabelState>(getContextFromState, t)
 })
 

packages/app/src/shell/component-tagger.ts

@@ -3,7 +3,7 @@ import type { Path } from "@effect/platform/Path"
 import { Effect, pipe } from "effect"
 import type { PluginOption } from "vite"
 
-import { componentPathAttributeName, isJsxFile, normalizeModuleId } from "../core/component-path.js"
+import { babelPluginName, componentPathAttributeName, isJsxFile, normalizeModuleId } from "../core/component-path.js"
 import { createJsxTaggerVisitor, type JsxTaggerContext } from "../core/jsx-tagger.js"
 import { NodePathLayer, relativeFromRoot } from "../core/path-service.js"
 
@@ -56,16 +56,12 @@ const toViteResult = (result: BabelTransformResult): ViteTransformResult | null
 // EFFECT: Babel AST transformation
 // INVARIANT: each JSX opening element has at most one path attribute
 // COMPLEXITY: O(n)/O(1), n = number of JSX elements
-type ViteBabelState = {
-  readonly context: JsxTaggerContext
-}
-
-const makeBabelTagger = (relativeFilename: string, attributeName: string): PluginObj<ViteBabelState> => {
+const makeBabelTagger = (relativeFilename: string, attributeName: string): PluginObj => {
   const context: JsxTaggerContext = { relativeFilename, attributeName }
 
   return {
-    name: "component-path-babel-tagger",
-    visitor: createJsxTaggerVisitor<ViteBabelState>(
+    name: babelPluginName,
+    visitor: createJsxTaggerVisitor(
       () => context,
       t
     )