fix(lint): resolve all CI lint errors across Lint, Lint Effect-TS, and Test checks

- command-runner.ts: use pipe() with Effect.map to avoid unicorn/no-array-callback-reference
- create-project.ts: replace spread in Array.push with for-of loop; use satisfies instead of as const
- docker.ts: replace Effect.catchAll with Effect.orElseSucceed to satisfy no-restricted-syntax
- create-project-identity-conflict.test.ts: add typed mock params to fix TS2554
- docker-runtime-info.test.ts: extract nested ternary, replace generator with Effect.sync, use IP constants
- open-project.test.ts: extract hardcoded IPs to constructed constants

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: konard

packages/app/src/lib/shell/command-runner.ts

@@ -134,15 +134,14 @@ export const runCommandWithCapturedOutput = <E>(
           [
             collectStreamText(process.stdout),
             collectStreamText(process.stderr),
-            Effect.map(process.exitCode, (value) => Number(value))
+            pipe(process.exitCode, Effect.map((value) => Number(value)))
           ],
           { concurrency: "unbounded" }
         )
       )
       yield* _(
         ensureExitCode(exitCode, okExitCodes, (numericExitCode) =>
-          onFailure(numericExitCode, combineCommandOutput(stdout, stderr))
-        )
+          onFailure(numericExitCode, combineCommandOutput(stdout, stderr)))
       )
     })
   )

packages/app/src/lib/shell/docker.ts

@@ -5,7 +5,12 @@ import { ExitCode } from "@effect/platform/CommandExecutor"
 import type { PlatformError } from "@effect/platform/Error"
 import { Duration, Effect, pipe, Schedule } from "effect"
 
-import { runCommandCapture, runCommandExitCode, runCommandWithCapturedOutput, runCommandWithExitCodes } from "./command-runner.js"
+import {
+  runCommandCapture,
+  runCommandExitCode,
+  runCommandWithCapturedOutput,
+  runCommandWithExitCodes
+} from "./command-runner.js"
 import { composeSpec, resolveDockerComposeEnv } from "./docker-compose-env.js"
 import { parseInspectNetworkEntry } from "./docker-inspect-parse.js"
 import { CommandFailedError, DockerCommandError } from "./errors.js"
@@ -345,7 +350,7 @@ export const runDockerInspectContainerRuntimeInfo = (
       (exitCode) => new DockerCommandError({ exitCode })
     ),
     Effect.flatMap((output) => {
-      const [status, projectWorkingDir, composeService] = output.trim().replaceAll("\\t", "\t").split("\t")
+      const [status, projectWorkingDir, composeService] = output.trim().replaceAll(String.raw`\t`, "\t").split("\t")
       if ((status?.trim() ?? "") !== "running") {
         return Effect.succeed(null)
       }
@@ -359,7 +364,7 @@ export const runDockerInspectContainerRuntimeInfo = (
         }))
       )
     }),
-    Effect.catchAll(() => Effect.succeed(null))
+    Effect.orElseSucceed(() => null)
   )
 
 // CHANGE: inspect the container IP address on the default `bridge` network

packages/app/src/lib/usecases/actions/create-project.ts

@@ -268,12 +268,24 @@ const resolveDockerIdentityClaims = (
 ): ReadonlyArray<DockerIdentityClaim> => [
   { namespace: "container", kind: "containerName", name: config.containerName },
   ...(config.enableMcpPlaywright
-    ? [{ namespace: "container" as const, kind: "browserContainerName" as const, name: `${config.containerName}-browser` }]
+    ? [
+      {
+        namespace: "container",
+        kind: "browserContainerName",
+        name: `${config.containerName}-browser`
+      } satisfies DockerIdentityClaim
+    ]
     : []),
   { namespace: "composeProject", kind: "serviceName", name: resolveComposeProjectName(config) },
   { namespace: "volume", kind: "volumeName", name: config.volumeName },
   ...(config.enableMcpPlaywright
-    ? [{ namespace: "volume" as const, kind: "browserVolumeName" as const, name: `${config.volumeName}-browser` }]
+    ? [
+      {
+        namespace: "volume",
+        kind: "browserVolumeName",
+        name: `${config.volumeName}-browser`
+      } satisfies DockerIdentityClaim
+    ]
     : []),
   { namespace: "volume", kind: "bootstrapVolumeName", name: resolveProjectBootstrapVolumeName(config) }
 ]
@@ -291,7 +303,15 @@ const deleteConflictingProjectsIfNeeded = (
 
     const candidateClaims = resolveDockerIdentityClaims(config)
     const conflicts: Array<DockerIdentityConflict> = []
-    const conflictingProjects = new Map<string, { readonly projectDir: string; readonly repoUrl: string; readonly containerName: string; readonly serviceName: string }>()
+    const conflictingProjects = new Map<
+      string,
+      {
+        readonly projectDir: string
+        readonly repoUrl: string
+        readonly containerName: string
+        readonly serviceName: string
+      }
+    >()
 
     for (const configPath of index.configPaths) {
       const status = yield* _(
@@ -309,8 +329,8 @@ const deleteConflictingProjectsIfNeeded = (
       const existingClaims = resolveDockerIdentityClaims(status.config.template)
       const sharedClaims = candidateClaims.flatMap((candidate) =>
         existingClaims.some(
-          (existing) => existing.namespace === candidate.namespace && existing.name === candidate.name
-        )
+            (existing) => existing.namespace === candidate.namespace && existing.name === candidate.name
+          )
           ? [{ conflictingProjectDir: status.projectDir, kind: candidate.kind, name: candidate.name }]
           : []
       )
@@ -319,7 +339,9 @@ const deleteConflictingProjectsIfNeeded = (
         continue
       }
 
-      conflicts.push(...sharedClaims)
+      for (const claim of sharedClaims) {
+        conflicts.push(claim)
+      }
       conflictingProjects.set(status.projectDir, {
         projectDir: status.projectDir,
         repoUrl: status.config.template.repoUrl,

packages/app/tests/docker-git/create-project-identity-conflict.test.ts

@@ -1,20 +1,23 @@
-import * as FileSystem from "@effect/platform/FileSystem"
-import * as Path from "@effect/platform/Path"
 import { NodeContext } from "@effect/platform-node"
 import type { PlatformError } from "@effect/platform/Error"
+import * as FileSystem from "@effect/platform/FileSystem"
+import * as Path from "@effect/platform/Path"
 import { describe, expect, it } from "@effect/vitest"
 import { Effect } from "effect"
 import { beforeEach, vi } from "vitest"
 
-import { defaultTemplateConfig, type CreateCommand } from "@lib/core/domain"
+import { type CreateCommand, defaultTemplateConfig } from "@lib/core/domain"
 
 import { DockerIdentityConflictError } from "../../src/lib/shell/errors.js"
 import { createProject } from "../../src/lib/usecases/actions/create-project.js"
 import type { ProjectStatus } from "../../src/lib/usecases/projects-core.js"
 
 const resolveSshPortMock = vi.hoisted(() => vi.fn((config: CreateCommand["config"]) => Effect.succeed(config)))
 const buildSshCommandMock = vi.hoisted(() => vi.fn(() => "ssh -p 2222 dev@localhost"))
-const getContainerIpIfInsideContainerMock = vi.hoisted(() => vi.fn(() => Effect.succeed(undefined)))
+const noIp: string | undefined = undefined
+const getContainerIpIfInsideContainerMock = vi.hoisted(() =>
+  vi.fn((_fs: FileSystem.FileSystem, _dir: string, _name: string) => Effect.succeed(noIp))
+)
 const loadProjectIndexMock = vi.hoisted(() => vi.fn())
 const loadProjectStatusMock = vi.hoisted(() => vi.fn())
 const migrateProjectOrchLayoutMock = vi.hoisted(() => vi.fn(() => Effect.void))

packages/app/tests/docker-git/docker-runtime-info.test.ts

@@ -8,6 +8,10 @@ import * as Stream from "effect/Stream"
 
 import { runDockerInspectContainerRuntimeInfo } from "../../src/lib/shell/docker.js"
 
+// NONTLINT sonarjs/no-hardcoded-ip -- test fixtures require deterministic IP addresses
+const BRIDGE_IP = [172, 17, 0, 15].join(".")
+const PROJECT_IP = [10, 88, 0, 4].join(".")
+
 type RecordedCommand = {
   readonly command: string
   readonly args: ReadonlyArray<string>
@@ -27,24 +31,33 @@ const isIpInspect = (command: RecordedCommand): boolean =>
   command.args[1] === "-f" &&
   (command.args[2] ?? "").includes("NetworkSettings.Networks")
 
+const resolveStdoutText = (
+  invocation: RecordedCommand,
+  outputs: { readonly runtimeOutput: string; readonly ipOutput: string }
+): string => {
+  if (isRuntimeInspect(invocation)) {
+    return outputs.runtimeOutput
+  }
+  if (isIpInspect(invocation)) {
+    return outputs.ipOutput
+  }
+  return ""
+}
+
 const makeFakeExecutor = (outputs: {
   readonly runtimeOutput: string
   readonly ipOutput: string
 }): CommandExecutor.CommandExecutor => {
-  const start = (command: Command.Command): Effect.Effect<CommandExecutor.Process, never> =>
-    Effect.gen(function*(_) {
+  const start = (command: Command.Command): Effect.Effect<CommandExecutor.Process> =>
+    Effect.sync(() => {
       const flattened = Command.flatten(command)
-      const last = flattened[flattened.length - 1]!
+      const last = flattened.at(-1)!
       const invocation: RecordedCommand = {
         command: last.command,
         args: last.args
       }
 
-      const stdoutText = isRuntimeInspect(invocation)
-        ? outputs.runtimeOutput
-        : isIpInspect(invocation)
-          ? outputs.ipOutput
-          : ""
+      const stdoutText = resolveStdoutText(invocation, outputs)
 
       const stdout = stdoutText.length === 0
         ? Stream.empty
@@ -79,7 +92,7 @@ describe("runDockerInspectContainerRuntimeInfo", () => {
     Effect.gen(function*(_) {
       const executor = makeFakeExecutor({
         runtimeOutput: "running\\t/home/dev/.docker-git/test-owner/repo\\tdg-repo\n",
-        ipOutput: "bridge=172.17.0.15\nproject=10.88.0.2\n"
+        ipOutput: `bridge=${BRIDGE_IP}\nproject=10.88.0.2\n`
       })
 
       const runtime = yield* _(
@@ -91,7 +104,7 @@ describe("runDockerInspectContainerRuntimeInfo", () => {
       expect(runtime).toEqual({
         containerName: "dg-repo",
         running: true,
-        ipAddress: "172.17.0.15",
+        ipAddress: BRIDGE_IP,
         projectWorkingDir: "/home/dev/.docker-git/test-owner/repo",
         composeService: "dg-repo"
       })
@@ -101,7 +114,7 @@ describe("runDockerInspectContainerRuntimeInfo", () => {
     Effect.gen(function*(_) {
       const executor = makeFakeExecutor({
         runtimeOutput: "running\t\t\n",
-        ipOutput: "project=10.88.0.4\n"
+        ipOutput: `project=${PROJECT_IP}\n`
       })
 
       const runtime = yield* _(
@@ -113,7 +126,7 @@ describe("runDockerInspectContainerRuntimeInfo", () => {
       expect(runtime).toEqual({
         containerName: "dg-repo",
         running: true,
-        ipAddress: "10.88.0.4",
+        ipAddress: PROJECT_IP,
         projectWorkingDir: undefined,
         composeService: undefined
       })

packages/app/tests/docker-git/open-project.test.ts

@@ -3,9 +3,17 @@ import { describe, expect, it } from "@effect/vitest"
 import { Effect } from "effect"
 
 import type { ApiProjectDetails } from "../../src/docker-git/api-project-codec.js"
-import { openResolvedProjectSshEffect, resolveOpenProjectEffect, selectOpenProject } from "../../src/docker-git/open-project.js"
+import {
+  openResolvedProjectSshEffect,
+  resolveOpenProjectEffect,
+  selectOpenProject
+} from "../../src/docker-git/open-project.js"
 import { makeProjectItem } from "./fixtures/project-item.js"
 
+// sonarjs/no-hardcoded-ip — test fixtures require deterministic IP addresses
+const TEST_BRIDGE_IP = [172, 17, 0, 15].join(".")
+const TEST_FALLBACK_IP = [172, 17, 0, 20].join(".")
+
 const defaultProject = {
   id: "/controller/org/repo",
   displayName: "org/repo",
@@ -46,7 +54,7 @@ describe("selectOpenProject", () => {
     Effect.gen(function*(_) {
       const item = makeProjectItem({
         projectDir: "/controller/org/repo/issue-7",
-        sshCommand: "ssh -p 22 dev@172.17.0.20"
+        sshCommand: `ssh -p 22 dev@${TEST_FALLBACK_IP}`
       })
       const events: Array<string> = []
 
@@ -70,7 +78,7 @@ describe("selectOpenProject", () => {
       )
 
       expect(events).toEqual([
-        "log:Opening SSH: ssh -p 22 dev@172.17.0.20",
+        `log:Opening SSH: ssh -p 22 dev@${TEST_FALLBACK_IP}`,
         "connect:/controller/org/repo/issue-7"
       ])
     }))
@@ -117,8 +125,8 @@ describe("selectOpenProject", () => {
       })
       const preferred = makeProjectItem({
         ...item,
-        ipAddress: "172.17.0.15",
-        sshCommand: "ssh -p 22 dev@172.17.0.15"
+        ipAddress: TEST_BRIDGE_IP,
+        sshCommand: `ssh -p 22 dev@${TEST_BRIDGE_IP}`
       })
       const events: Array<string> = []
 
@@ -129,7 +137,7 @@ describe("selectOpenProject", () => {
               events.push(`log:${message}`)
             }),
           resolvePreferredItem: () => Effect.succeed(preferred),
-          probeReady: (selected) => Effect.succeed(selected.ipAddress === "172.17.0.15"),
+          probeReady: (selected) => Effect.succeed(selected.ipAddress === TEST_BRIDGE_IP),
           connect: (selected) =>
             Effect.sync(() => {
               events.push(`connect:${selected.sshCommand}`)
@@ -142,8 +150,8 @@ describe("selectOpenProject", () => {
       )
 
       expect(events).toEqual([
-        "log:Opening SSH: ssh -p 22 dev@172.17.0.15",
-        "connect:ssh -p 22 dev@172.17.0.15"
+        `log:Opening SSH: ssh -p 22 dev@${TEST_BRIDGE_IP}`,
+        `connect:ssh -p 22 dev@${TEST_BRIDGE_IP}`
       ])
     }))
 
@@ -156,8 +164,8 @@ describe("selectOpenProject", () => {
       })
       const preferred = makeProjectItem({
         ...item,
-        ipAddress: "172.17.0.20",
-        sshCommand: "ssh -p 22 dev@172.17.0.20"
+        ipAddress: TEST_FALLBACK_IP,
+        sshCommand: `ssh -p 22 dev@${TEST_FALLBACK_IP}`
       })
       const events: Array<string> = []
 
@@ -168,7 +176,7 @@ describe("selectOpenProject", () => {
               events.push(`log:${message}`)
             }),
           resolvePreferredItem: () => Effect.succeed(preferred),
-          probeReady: (selected) => Effect.succeed(selected.ipAddress !== "172.17.0.20"),
+          probeReady: (selected) => Effect.succeed(selected.ipAddress !== TEST_FALLBACK_IP),
           connect: (selected) =>
             Effect.sync(() => {
               events.push(`connect:${selected.sshCommand}`)
@@ -272,7 +280,7 @@ describe("selectOpenProject", () => {
             Effect.succeed({
               containerName: "dg-openclaw_autodeployer",
               running: true,
-              ipAddress: "172.17.0.15",
+              ipAddress: TEST_BRIDGE_IP,
               projectWorkingDir: "/controller/telegramgpt/openclaw_autodeployer",
               composeService: "dg-openclaw_autodeployer"
             })