Skip to content

Commit a7a40f3

Browse files
konardclaude
andcommitted
fix(lint): resolve Effect-TS lint errors in packages/app
- Replace Effect.catchAll with explicit Effect.catchTags in docker.ts - Replace `as const` casts with `satisfies` in create-project.ts - Replace spread in Array.push with for-of loop - Use pipe-style Effect.map to avoid unicorn/no-array-callback-reference Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 902c964 commit a7a40f3

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

packages/app/src/lib/shell/command-runner.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ export const runCommandWithCapturedOutput = <E>(
134134
[
135135
collectStreamText(process.stdout),
136136
collectStreamText(process.stderr),
137-
Effect.map(process.exitCode, (value) => Number(value))
137+
process.exitCode.pipe(Effect.map((value) => Number(value)))
138138
],
139139
{ concurrency: "unbounded" }
140140
)

packages/app/src/lib/shell/docker.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,7 @@ export const runDockerInspectContainerRuntimeInfo = (
359359
}))
360360
)
361361
}),
362-
Effect.catchAll(() => Effect.succeed(null))
362+
Effect.catchTags({ DockerCommandError: () => Effect.succeed(null), SystemError: () => Effect.succeed(null), BadArgument: () => Effect.succeed(null) })
363363
)
364364

365365
// CHANGE: inspect the container IP address on the default `bridge` network

packages/app/src/lib/usecases/actions/create-project.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -268,12 +268,12 @@ const resolveDockerIdentityClaims = (
268268
): ReadonlyArray<DockerIdentityClaim> => [
269269
{ namespace: "container", kind: "containerName", name: config.containerName },
270270
...(config.enableMcpPlaywright
271-
? [{ namespace: "container" as const, kind: "browserContainerName" as const, name: `${config.containerName}-browser` }]
271+
? [{ namespace: "container", kind: "browserContainerName", name: `${config.containerName}-browser` } satisfies DockerIdentityClaim]
272272
: []),
273273
{ namespace: "composeProject", kind: "serviceName", name: resolveComposeProjectName(config) },
274274
{ namespace: "volume", kind: "volumeName", name: config.volumeName },
275275
...(config.enableMcpPlaywright
276-
? [{ namespace: "volume" as const, kind: "browserVolumeName" as const, name: `${config.volumeName}-browser` }]
276+
? [{ namespace: "volume", kind: "browserVolumeName", name: `${config.volumeName}-browser` } satisfies DockerIdentityClaim]
277277
: []),
278278
{ namespace: "volume", kind: "bootstrapVolumeName", name: resolveProjectBootstrapVolumeName(config) }
279279
]
@@ -319,7 +319,7 @@ const deleteConflictingProjectsIfNeeded = (
319319
continue
320320
}
321321

322-
conflicts.push(...sharedClaims)
322+
for (const claim of sharedClaims) { conflicts.push(claim) }
323323
conflictingProjects.set(status.projectDir, {
324324
projectDir: status.projectDir,
325325
repoUrl: status.config.template.repoUrl,

0 commit comments

Comments
 (0)