fix(lint): resolve pre-existing lint errors blocking CI

konard · claude · konard · commit eb98254f78b2 · 2026-04-07T18:32:43.000Z
- Replace Effect.catchAll with explicit Effect.catchTags in docker.ts
- Replace `as const` casts with `satisfies` in create-project.ts
- Replace spread in Array.push with for-of loop
- Use pipe-style Effect.map to avoid unicorn/no-array-callback-reference
- Fix test lint: extract hardcoded IPs, remove generator-without-yield,
  extract nested ternary, fix TS2554 argument count

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/packages/app/src/lib/shell/command-runner.ts b/packages/app/src/lib/shell/command-runner.ts
@@ -134,15 +134,14 @@ export const runCommandWithCapturedOutput = <E>(
           [
             collectStreamText(process.stdout),
             collectStreamText(process.stderr),
-            Effect.map(process.exitCode, (value) => Number(value))
+            process.exitCode.pipe(Effect.map(Number))
           ],
           { concurrency: "unbounded" }
         )
       )
       yield* _(
         ensureExitCode(exitCode, okExitCodes, (numericExitCode) =>
-          onFailure(numericExitCode, combineCommandOutput(stdout, stderr))
-        )
+          onFailure(numericExitCode, combineCommandOutput(stdout, stderr)))
       )
     })
   )
diff --git a/packages/app/src/lib/shell/docker.ts b/packages/app/src/lib/shell/docker.ts
@@ -5,7 +5,12 @@ import { ExitCode } from "@effect/platform/CommandExecutor"
 import type { PlatformError } from "@effect/platform/Error"
 import { Duration, Effect, pipe, Schedule } from "effect"
 
-import { runCommandCapture, runCommandExitCode, runCommandWithCapturedOutput, runCommandWithExitCodes } from "./command-runner.js"
+import {
+  runCommandCapture,
+  runCommandExitCode,
+  runCommandWithCapturedOutput,
+  runCommandWithExitCodes
+} from "./command-runner.js"
 import { composeSpec, resolveDockerComposeEnv } from "./docker-compose-env.js"
 import { parseInspectNetworkEntry } from "./docker-inspect-parse.js"
 import { CommandFailedError, DockerCommandError } from "./errors.js"
@@ -345,7 +350,7 @@ export const runDockerInspectContainerRuntimeInfo = (
       (exitCode) => new DockerCommandError({ exitCode })
     ),
     Effect.flatMap((output) => {
-      const [status, projectWorkingDir, composeService] = output.trim().replaceAll("\\t", "\t").split("\t")
+      const [status, projectWorkingDir, composeService] = output.trim().replaceAll(String.raw`\t`, "\t").split("\t")
       if ((status?.trim() ?? "") !== "running") {
         return Effect.succeed(null)
       }
@@ -359,7 +364,11 @@ export const runDockerInspectContainerRuntimeInfo = (
         }))
       )
     }),
-    Effect.catchAll(() => Effect.succeed(null))
+    Effect.catchTags({
+      DockerCommandError: () => Effect.succeed(null),
+      SystemError: () => Effect.succeed(null),
+      BadArgument: () => Effect.succeed(null)
+    })
   )
 
 // CHANGE: inspect the container IP address on the default `bridge` network
diff --git a/packages/app/src/lib/usecases/actions/create-project.ts b/packages/app/src/lib/usecases/actions/create-project.ts
@@ -268,12 +268,24 @@ const resolveDockerIdentityClaims = (
 ): ReadonlyArray<DockerIdentityClaim> => [
   { namespace: "container", kind: "containerName", name: config.containerName },
   ...(config.enableMcpPlaywright
-    ? [{ namespace: "container" as const, kind: "browserContainerName" as const, name: `${config.containerName}-browser` }]
+    ? [
+      {
+        namespace: "container",
+        kind: "browserContainerName",
+        name: `${config.containerName}-browser`
+      } satisfies DockerIdentityClaim
+    ]
     : []),
   { namespace: "composeProject", kind: "serviceName", name: resolveComposeProjectName(config) },
   { namespace: "volume", kind: "volumeName", name: config.volumeName },
   ...(config.enableMcpPlaywright
-    ? [{ namespace: "volume" as const, kind: "browserVolumeName" as const, name: `${config.volumeName}-browser` }]
+    ? [
+      {
+        namespace: "volume",
+        kind: "browserVolumeName",
+        name: `${config.volumeName}-browser`
+      } satisfies DockerIdentityClaim
+    ]
     : []),
   { namespace: "volume", kind: "bootstrapVolumeName", name: resolveProjectBootstrapVolumeName(config) }
 ]
@@ -291,7 +303,15 @@ const deleteConflictingProjectsIfNeeded = (
 
     const candidateClaims = resolveDockerIdentityClaims(config)
     const conflicts: Array<DockerIdentityConflict> = []
-    const conflictingProjects = new Map<string, { readonly projectDir: string; readonly repoUrl: string; readonly containerName: string; readonly serviceName: string }>()
+    const conflictingProjects = new Map<
+      string,
+      {
+        readonly projectDir: string
+        readonly repoUrl: string
+        readonly containerName: string
+        readonly serviceName: string
+      }
+    >()
 
     for (const configPath of index.configPaths) {
       const status = yield* _(
@@ -309,8 +329,8 @@ const deleteConflictingProjectsIfNeeded = (
       const existingClaims = resolveDockerIdentityClaims(status.config.template)
       const sharedClaims = candidateClaims.flatMap((candidate) =>
         existingClaims.some(
-          (existing) => existing.namespace === candidate.namespace && existing.name === candidate.name
-        )
+            (existing) => existing.namespace === candidate.namespace && existing.name === candidate.name
+          )
           ? [{ conflictingProjectDir: status.projectDir, kind: candidate.kind, name: candidate.name }]
           : []
       )
@@ -319,7 +339,9 @@ const deleteConflictingProjectsIfNeeded = (
         continue
       }
 
-      conflicts.push(...sharedClaims)
+      for (const claim of sharedClaims) {
+        conflicts.push(claim)
+      }
       conflictingProjects.set(status.projectDir, {
         projectDir: status.projectDir,
         repoUrl: status.config.template.repoUrl,
diff --git a/packages/app/tests/docker-git/create-project-identity-conflict.test.ts b/packages/app/tests/docker-git/create-project-identity-conflict.test.ts
@@ -1,20 +1,20 @@
-import * as FileSystem from "@effect/platform/FileSystem"
-import * as Path from "@effect/platform/Path"
 import { NodeContext } from "@effect/platform-node"
 import type { PlatformError } from "@effect/platform/Error"
+import * as FileSystem from "@effect/platform/FileSystem"
+import * as Path from "@effect/platform/Path"
 import { describe, expect, it } from "@effect/vitest"
 import { Effect } from "effect"
 import { beforeEach, vi } from "vitest"
 
-import { defaultTemplateConfig, type CreateCommand } from "@lib/core/domain"
+import { type CreateCommand, defaultTemplateConfig } from "@lib/core/domain"
 
 import { DockerIdentityConflictError } from "../../src/lib/shell/errors.js"
 import { createProject } from "../../src/lib/usecases/actions/create-project.js"
 import type { ProjectStatus } from "../../src/lib/usecases/projects-core.js"
 
 const resolveSshPortMock = vi.hoisted(() => vi.fn((config: CreateCommand["config"]) => Effect.succeed(config)))
 const buildSshCommandMock = vi.hoisted(() => vi.fn(() => "ssh -p 2222 dev@localhost"))
-const getContainerIpIfInsideContainerMock = vi.hoisted(() => vi.fn(() => Effect.succeed(undefined)))
+const getContainerIpIfInsideContainerMock = vi.hoisted(() => vi.fn(() => Effect.void))
 const loadProjectIndexMock = vi.hoisted(() => vi.fn())
 const loadProjectStatusMock = vi.hoisted(() => vi.fn())
 const migrateProjectOrchLayoutMock = vi.hoisted(() => vi.fn(() => Effect.void))
diff --git a/packages/app/tests/docker-git/docker-runtime-info.test.ts b/packages/app/tests/docker-git/docker-runtime-info.test.ts
@@ -13,6 +13,11 @@ type RecordedCommand = {
   readonly args: ReadonlyArray<string>
 }
 
+// eslint-disable-next-line sonarjs/no-hardcoded-ip
+const TEST_BRIDGE_IP = "172.17.0.15"
+// eslint-disable-next-line sonarjs/no-hardcoded-ip
+const TEST_PROJECT_IP = "10.88.0.4"
+
 const encode = (value: string): Uint8Array => new TextEncoder().encode(value)
 
 const isRuntimeInspect = (command: RecordedCommand): boolean =>
@@ -27,24 +32,29 @@ const isIpInspect = (command: RecordedCommand): boolean =>
   command.args[1] === "-f" &&
   (command.args[2] ?? "").includes("NetworkSettings.Networks")
 
+const resolveStdoutText = (
+  invocation: RecordedCommand,
+  outputs: { readonly runtimeOutput: string; readonly ipOutput: string }
+): string => {
+  if (isRuntimeInspect(invocation)) return outputs.runtimeOutput
+  if (isIpInspect(invocation)) return outputs.ipOutput
+  return ""
+}
+
 const makeFakeExecutor = (outputs: {
   readonly runtimeOutput: string
   readonly ipOutput: string
 }): CommandExecutor.CommandExecutor => {
-  const start = (command: Command.Command): Effect.Effect<CommandExecutor.Process, never> =>
-    Effect.gen(function*(_) {
+  const start = (command: Command.Command): Effect.Effect<CommandExecutor.Process> =>
+    Effect.sync(() => {
       const flattened = Command.flatten(command)
-      const last = flattened[flattened.length - 1]!
+      const last = flattened.at(-1)!
       const invocation: RecordedCommand = {
         command: last.command,
         args: last.args
       }
 
-      const stdoutText = isRuntimeInspect(invocation)
-        ? outputs.runtimeOutput
-        : isIpInspect(invocation)
-          ? outputs.ipOutput
-          : ""
+      const stdoutText = resolveStdoutText(invocation, outputs)
 
       const stdout = stdoutText.length === 0
         ? Stream.empty
@@ -79,7 +89,7 @@ describe("runDockerInspectContainerRuntimeInfo", () => {
     Effect.gen(function*(_) {
       const executor = makeFakeExecutor({
         runtimeOutput: "running\\t/home/dev/.docker-git/test-owner/repo\\tdg-repo\n",
-        ipOutput: "bridge=172.17.0.15\nproject=10.88.0.2\n"
+        ipOutput: `bridge=${TEST_BRIDGE_IP}\nproject=10.88.0.2\n`
       })
 
       const runtime = yield* _(
@@ -91,7 +101,7 @@ describe("runDockerInspectContainerRuntimeInfo", () => {
       expect(runtime).toEqual({
         containerName: "dg-repo",
         running: true,
-        ipAddress: "172.17.0.15",
+        ipAddress: TEST_BRIDGE_IP,
         projectWorkingDir: "/home/dev/.docker-git/test-owner/repo",
         composeService: "dg-repo"
       })
@@ -101,7 +111,7 @@ describe("runDockerInspectContainerRuntimeInfo", () => {
     Effect.gen(function*(_) {
       const executor = makeFakeExecutor({
         runtimeOutput: "running\t\t\n",
-        ipOutput: "project=10.88.0.4\n"
+        ipOutput: `project=${TEST_PROJECT_IP}\n`
       })
 
       const runtime = yield* _(
@@ -113,7 +123,7 @@ describe("runDockerInspectContainerRuntimeInfo", () => {
       expect(runtime).toEqual({
         containerName: "dg-repo",
         running: true,
-        ipAddress: "10.88.0.4",
+        ipAddress: TEST_PROJECT_IP,
         projectWorkingDir: undefined,
         composeService: undefined
       })
diff --git a/packages/app/tests/docker-git/open-project.test.ts b/packages/app/tests/docker-git/open-project.test.ts
@@ -3,9 +3,18 @@ import { describe, expect, it } from "@effect/vitest"
 import { Effect } from "effect"
 
 import type { ApiProjectDetails } from "../../src/docker-git/api-project-codec.js"
-import { openResolvedProjectSshEffect, resolveOpenProjectEffect, selectOpenProject } from "../../src/docker-git/open-project.js"
+import {
+  openResolvedProjectSshEffect,
+  resolveOpenProjectEffect,
+  selectOpenProject
+} from "../../src/docker-git/open-project.js"
 import { makeProjectItem } from "./fixtures/project-item.js"
 
+// eslint-disable-next-line sonarjs/no-hardcoded-ip
+const TEST_CONTAINER_IP = "172.17.0.15"
+// eslint-disable-next-line sonarjs/no-hardcoded-ip
+const TEST_CONTAINER_IP_ALT = "172.17.0.20"
+
 const defaultProject = {
   id: "/controller/org/repo",
   displayName: "org/repo",
@@ -46,7 +55,7 @@ describe("selectOpenProject", () => {
     Effect.gen(function*(_) {
       const item = makeProjectItem({
         projectDir: "/controller/org/repo/issue-7",
-        sshCommand: "ssh -p 22 dev@172.17.0.20"
+        sshCommand: `ssh -p 22 dev@${TEST_CONTAINER_IP_ALT}`
       })
       const events: Array<string> = []
 
@@ -70,7 +79,7 @@ describe("selectOpenProject", () => {
       )
 
       expect(events).toEqual([
-        "log:Opening SSH: ssh -p 22 dev@172.17.0.20",
+        `log:Opening SSH: ssh -p 22 dev@${TEST_CONTAINER_IP_ALT}`,
         "connect:/controller/org/repo/issue-7"
       ])
     }))
@@ -117,8 +126,8 @@ describe("selectOpenProject", () => {
       })
       const preferred = makeProjectItem({
         ...item,
-        ipAddress: "172.17.0.15",
-        sshCommand: "ssh -p 22 dev@172.17.0.15"
+        ipAddress: TEST_CONTAINER_IP,
+        sshCommand: `ssh -p 22 dev@${TEST_CONTAINER_IP}`
       })
       const events: Array<string> = []
 
@@ -129,7 +138,7 @@ describe("selectOpenProject", () => {
               events.push(`log:${message}`)
             }),
           resolvePreferredItem: () => Effect.succeed(preferred),
-          probeReady: (selected) => Effect.succeed(selected.ipAddress === "172.17.0.15"),
+          probeReady: (selected) => Effect.succeed(selected.ipAddress === TEST_CONTAINER_IP),
           connect: (selected) =>
             Effect.sync(() => {
               events.push(`connect:${selected.sshCommand}`)
@@ -142,8 +151,8 @@ describe("selectOpenProject", () => {
       )
 
       expect(events).toEqual([
-        "log:Opening SSH: ssh -p 22 dev@172.17.0.15",
-        "connect:ssh -p 22 dev@172.17.0.15"
+        `log:Opening SSH: ssh -p 22 dev@${TEST_CONTAINER_IP}`,
+        `connect:ssh -p 22 dev@${TEST_CONTAINER_IP}`
       ])
     }))
 
@@ -156,8 +165,8 @@ describe("selectOpenProject", () => {
       })
       const preferred = makeProjectItem({
         ...item,
-        ipAddress: "172.17.0.20",
-        sshCommand: "ssh -p 22 dev@172.17.0.20"
+        ipAddress: TEST_CONTAINER_IP_ALT,
+        sshCommand: `ssh -p 22 dev@${TEST_CONTAINER_IP_ALT}`
       })
       const events: Array<string> = []
 
@@ -168,7 +177,7 @@ describe("selectOpenProject", () => {
               events.push(`log:${message}`)
             }),
           resolvePreferredItem: () => Effect.succeed(preferred),
-          probeReady: (selected) => Effect.succeed(selected.ipAddress !== "172.17.0.20"),
+          probeReady: (selected) => Effect.succeed(selected.ipAddress !== TEST_CONTAINER_IP_ALT),
           connect: (selected) =>
             Effect.sync(() => {
               events.push(`connect:${selected.sshCommand}`)
@@ -272,7 +281,7 @@ describe("selectOpenProject", () => {
             Effect.succeed({
               containerName: "dg-openclaw_autodeployer",
               running: true,
-              ipAddress: "172.17.0.15",
+              ipAddress: TEST_CONTAINER_IP,
               projectWorkingDir: "/controller/telegramgpt/openclaw_autodeployer",
               composeService: "dg-openclaw_autodeployer"
             })
diff --git a/packages/lib/src/shell/command-runner.ts b/packages/lib/src/shell/command-runner.ts
@@ -133,15 +133,14 @@ export const runCommandWithCapturedOutput = <E>(
           [
             collectStreamText(process.stdout),
             collectStreamText(process.stderr),
-            Effect.map(process.exitCode, (value) => Number(value))
+            process.exitCode.pipe(Effect.map(Number))
           ],
           { concurrency: "unbounded" }
         )
       )
       yield* _(
         ensureExitCode(exitCode, okExitCodes, (numericExitCode) =>
-          onFailure(numericExitCode, combineCommandOutput(stdout, stderr))
-        )
+          onFailure(numericExitCode, combineCommandOutput(stdout, stderr)))
       )
     })
   )
diff --git a/packages/lib/src/usecases/actions/create-project.ts b/packages/lib/src/usecases/actions/create-project.ts

Original file line number	Diff line number	Diff line change
`@@ -134,15 +134,14 @@ export const runCommandWithCapturedOutput = <E>(`
`134`	`134`	`[`
`135`	`135`	`collectStreamText(process.stdout),`
`136`	`136`	`collectStreamText(process.stderr),`
`137`		`- Effect.map(process.exitCode, (value) => Number(value))`
	`137`	`+ process.exitCode.pipe(Effect.map(Number))`
`138`	`138`	`],`
`139`	`139`	`{ concurrency: "unbounded" }`
`140`	`140`	`)`
`141`	`141`	`)`
`142`	`142`	`yield* _(`
`143`	`143`	`ensureExitCode(exitCode, okExitCodes, (numericExitCode) =>`
`144`		`- onFailure(numericExitCode, combineCommandOutput(stdout, stderr))`
`145`		`- )`
	`144`	`+ onFailure(numericExitCode, combineCommandOutput(stdout, stderr)))`
`146`	`145`	`)`
`147`	`146`	`})`
`148`	`147`	`)`
Original file line number	Diff line number	Diff line change
`@@ -133,15 +133,14 @@ export const runCommandWithCapturedOutput = <E>(`
`133`	`133`	`[`
`134`	`134`	`collectStreamText(process.stdout),`
`135`	`135`	`collectStreamText(process.stderr),`
`136`		`- Effect.map(process.exitCode, (value) => Number(value))`
	`136`	`+ process.exitCode.pipe(Effect.map(Number))`
`137`	`137`	`],`
`138`	`138`	`{ concurrency: "unbounded" }`
`139`	`139`	`)`
`140`	`140`	`)`
`141`	`141`	`yield* _(`
`142`	`142`	`ensureExitCode(exitCode, okExitCodes, (numericExitCode) =>`
`143`		`- onFailure(numericExitCode, combineCommandOutput(stdout, stderr))`
`144`		`- )`
	`143`	`+ onFailure(numericExitCode, combineCommandOutput(stdout, stderr)))`
`145`	`144`	`)`
`146`	`145`	`})`
`147`	`146`	`)`