Fix SonarQube

Author: Pryanik0071

task_manager/statuses/views.py

@@ -8,6 +8,9 @@
 from task_manager.tasks.models import Task
 
 
+STATUS = "/statuses/"
+
+
 class IndexView(CustomLoginRequiredMixin):
 
     def get(self, request, *args, **kwargs):
@@ -36,7 +39,7 @@ def post(self, request, *args, **kwargs):
                                  messages.SUCCESS,
                                  _("Status created successfully"))
             form.save()
-            return redirect('/statuses/')
+            return redirect(STATUS)
         return render(request, self.template, self.get_context_data(form))
 
 
@@ -69,7 +72,7 @@ def post(self, request, *args, **kwargs):
                                  messages.SUCCESS,
                                  _("Status successfully changed"))
             form.save()
-            return redirect('/statuses/')
+            return redirect(STATUS)
         return render(request, self.template,
                       self.get_context_data(form, status))
 
@@ -100,8 +103,8 @@ def post(self, request, *args, **kwargs):
                 messages.error(
                     request, _("Cannot delete status because it is in use.")
                 )
-                return redirect('/statuses/')
+                return redirect(STATUS)
             else:
                 status.delete()
                 messages.success(request, _("Status successfully deleted"))
-        return redirect('/statuses/')
+        return redirect(STATUS)

task_manager/tasks/views.py

@@ -9,6 +9,9 @@
 from task_manager.mixins import CustomLoginRequiredMixin
 
 
+TASKS = '/tasks/'
+
+
 class BaseTaskView(CustomLoginRequiredMixin):
     def get_task(self):
         pk = self.kwargs.get('pk')
@@ -59,7 +62,7 @@ def post(self, request, *args, **kwargs):
             messages.add_message(request,
                                  messages.SUCCESS,
                                  _("Task created successfully"))
-            return redirect('/tasks/')
+            return redirect(TASKS)
         return render(request, self.template,
                       self.get_context_data(form))
 
@@ -89,7 +92,7 @@ def post(self, request, *args, **kwargs):
                                  messages.SUCCESS,
                                  _("Task successfully changed"))
             form.save()
-            return redirect('/tasks/')
+            return redirect(TASKS)
         return render(request, self.template,
                       self.get_context_data(form, task))
 
@@ -108,7 +111,7 @@ def get(self, request, *args, **kwargs):
         task = self.get_task()
         if task.author != self.request.user:
             messages.error(request, _("Only the author can delete the task"))
-            return redirect('/tasks/')
+            return redirect(TASKS)
         return render(request, 'tasks/delete.html',
                       self.get_context_data(task))
 
@@ -117,4 +120,4 @@ def post(self, request, *args, **kwargs):
         if task:
             task.delete()
             messages.success(request, _("Task successfully deleted"))
-        return redirect('/tasks/')
+        return redirect(TASKS)

task_manager/users/views.py

@@ -9,6 +9,9 @@
 from task_manager.tasks.models import Task
 
 
+USERS = "/login/"
+
+
 class IndexView(View):
 
     def get(self, request, *args, **kwargs):
@@ -40,7 +43,7 @@ def post(self, request, *args, **kwargs):
                                  messages.SUCCESS,
                                  _("User registered successfully"))
             form.save()
-            return redirect('/login/')
+            return redirect(USERS)
         return render(request, self.template,
                       self.get_context_data(form))
 
@@ -74,7 +77,7 @@ def post(self, request, *args, **kwargs):
                                  messages.SUCCESS,
                                  _("User successfully changed"))
             form.save()
-            return redirect('/users/')
+            return redirect(USERS)
         return render(request, self.template,
                       self.get_context_data(form, user))
 
@@ -109,8 +112,8 @@ def post(self, request, *args, **kwargs):
                     request,
                     _("Cannot delete user because they are assigned to tasks.")
                 )
-                return redirect('/users/')
+                return redirect(USERS)
             else:
                 user.delete()
                 messages.success(request, _("User successfully deleted"))
-        return redirect('/users/')
+        return redirect(USERS)