Skip to content

Commit e0c8d98

Browse files
committed
Fix SonarQube
1 parent 13ffcca commit e0c8d98

3 files changed

Lines changed: 8 additions & 18 deletions

File tree

task_manager/labels/views.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@
88
from task_manager.tasks.models import Task
99

1010

11+
LABELS = '/labels/'
12+
13+
1114
class IndexView(CustomLoginRequiredMixin):
1215

1316
def get(self, request, *args, **kwargs):
@@ -36,7 +39,7 @@ def post(self, request, *args, **kwargs):
3639
messages.SUCCESS,
3740
_("Label created successfully"))
3841
form.save()
39-
return redirect('/labels/')
42+
return redirect(LABELS)
4043
return render(request, self.template, self.get_context_data(form))
4144

4245

@@ -70,7 +73,7 @@ def post(self, request, *args, **kwargs):
7073
messages.SUCCESS,
7174
_("Label successfully changed"))
7275
form.save()
73-
return redirect('/labels/')
76+
return redirect(LABELS)
7477
return render(
7578
request, self.template, self.get_context_data(form, label)
7679
)
@@ -104,8 +107,8 @@ def post(self, request, *args, **kwargs):
104107
request,
105108
_("Cannot delete label because it is in use.")
106109
)
107-
return redirect('/labels/')
110+
return redirect(LABELS)
108111
else:
109112
label.delete()
110113
messages.success(request, _("Label successfully deleted"))
111-
return redirect('/labels/')
114+
return redirect(LABELS)

task_manager/settings.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -115,24 +115,12 @@
115115
# https://docs.djangoproject.com/en/5.1/ref/settings/#auth-password-validators
116116

117117
AUTH_PASSWORD_VALIDATORS = [
118-
# {
119-
# 'NAME': 'django.contrib.auth.password_validation.UserAttributeSimilarityValidator',
120-
# },
121118
{
122119
'NAME': 'django.contrib.auth.password_validation.MinimumLengthValidator',
123120
'OPTIONS': {
124121
'min_length': 3,
125122
}
126123
},
127-
# {
128-
# 'NAME': 'django.contrib.auth.password_validation.SetUnusablePasswordMixin',
129-
# },
130-
# {
131-
# 'NAME': 'django.contrib.auth.password_validation.CommonPasswordValidator',
132-
# },
133-
# {
134-
# 'NAME': 'django.contrib.auth.password_validation.NumericPasswordValidator',
135-
# },
136124
]
137125

138126

task_manager/tasks/models.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@
1010
class Task(models.Model):
1111
name = models.CharField(max_length=150, unique=True,
1212
verbose_name=_("Name"))
13-
description = models.TextField(null=True, blank=True,
14-
verbose_name=_("Description"))
13+
description = models.TextField(blank=True, verbose_name=_("Description"))
1514
status = models.ForeignKey(Status, on_delete=models.PROTECT,
1615
verbose_name=_("Status"))
1716
author = models.ForeignKey(User, related_name='authored_tasks',

0 commit comments

Comments
 (0)