Raise error in proper places

[theSage21]

It might be a good idea to use abort(404, <reason>) in some places like

• PyJudge/server.py

  Line 89 in e3debe1

  return "Contest does not exist"

• PyJudge/server.py

  Line 102 in e3debe1

  return "Contest does not exist"

some places however don't require the error. For example this

• PyJudge/server.py

  Line 104 in e3debe1

  return "The contest had not started yet."

does not require an error.

[soumilk]

I would like to take this issue,
basically in this, instead of a statement "contest does not exist", we should raise an abort 404 page error ?

[theSage21]

that's the basic idea. you will need to find other places in the code where this has to be done.

[soumilk]

ohk ... i am on it

[soumilk]

I have gone through the server.py and it seems that it has raised abort(404) at certain places already, couldn't find places which require error. Help required .
And I thought to add a cool looking error page 404. Have a look, we can add it to the project.

[theSage21]

well, there are a few places where we are returning the string "contest inactive" or something like that. I was thinking if we could turn that into these pages it would be nice.

As for the 404 page it does look cool 😍 but you'll need to accomodate ALL error codes and not just 404 since that template gets called for ALL errors