Clear features attribute when load from config

Fix and extend tests

Author: Tomas-Pytel

fastapi_featureflags/main.py

@@ -9,13 +9,15 @@ class FeatureFlags(object):
 
     @staticmethod
     def load_conf_from_url(conf_from_url):
+        FeatureFlags.features.clear()
         FeatureFlags.conf_from_url = conf_from_url
         params = requests.get(conf_from_url).json()
         for k, v in params.items():
             FeatureFlags.features[k] = v
 
     @staticmethod
     def load_conf_from_json(conf_from_json):
+        FeatureFlags.features.clear()
         FeatureFlags.conf_from_json = conf_from_json
         with open(conf_from_json, "r") as f:
             params = json.loads(f.read())

tests/conftest.py

@@ -1,12 +1,13 @@
-import pytest
 import sys
 from pathlib import Path
 
-sys.path.append(str(Path(".").absolute().parent))
+import pytest
 
 from fastapi_featureflags import FeatureFlags
 
+sys.path.append(str(Path(".").absolute().parent))
+
 
 @pytest.fixture(scope="module")
 def featureflags():
-    return FeatureFlags()
+    return FeatureFlags

tests/features.json

@@ -1,7 +1,7 @@
 {
   "json_only": false,
-  "ps": true,
-  "mam": false,
-  "ror": true,
-  "dd": true
+  "file_1": true,
+  "file_2": false,
+  "file_3": true,
+  "file_4": true
 }

tests/test_1.py

@@ -0,0 +1,25 @@
+def test_ff_from_json(featureflags):
+    featureflags.load_conf_from_json("tests/features.json")
+    assert type(featureflags.get_features()) is dict
+    assert featureflags.get_features() == {
+        "json_only": False,
+        "file_1": True,
+        "file_2": False,
+        "file_3": True,
+        "file_4": True
+    }
+
+
+def test_reload_features(featureflags):
+    assert featureflags.get_features()["json_only"] is False
+    assert featureflags.get_features()["file_1"] is True
+
+    featureflags.enable_feature("json_only")
+    featureflags.disable_feature("file_1")
+    assert featureflags.get_features()["json_only"] is True
+    assert featureflags.get_features()["file_1"] is False
+
+    action = featureflags.reload_feature_flags()
+    assert action is True
+    assert featureflags.get_features()["json_only"] is False
+    assert featureflags.get_features()["file_1"] is True

tests/test_conf_from_json.py

@@ -0,0 +1,45 @@
+from fastapi_featureflags import feature_enabled
+
+
+def test_ff_from_url(featureflags):
+    featureflags.load_conf_from_url("https://pastebin.com/raw/4Ai3j2DC")
+    assert type(featureflags.get_features()) is dict
+    assert featureflags.get_features() == {
+        "web_only": False,
+        "web_1": True,
+        "web_2": False,
+        "web_3": True,
+        "web_4": False
+    }
+
+
+def test_enable_feature(featureflags):
+    assert featureflags.get_features()["web_only"] is False
+    action = featureflags.enable_feature("web_only")
+    assert action is True
+    assert featureflags.get_features()["web_only"] is True
+
+
+def test_disable_feature(featureflags):
+    assert featureflags.get_features()["web_1"] is True
+    action = featureflags.disable_feature("web_1")
+    assert action is False
+    assert featureflags.get_features()["web_1"] is False
+
+
+def test_feature_enabled(featureflags):
+    assert featureflags.get_features()["web_4"] is False
+    assert feature_enabled("web_4") is False
+    assert featureflags.is_enabled("web_4") is False
+    featureflags.enable_feature("web_4")
+    assert feature_enabled("web_4") is True
+    assert featureflags.is_enabled("web_4") is True
+
+
+def test_reload_features(featureflags):
+    assert featureflags.get_features()["web_only"] is True
+    assert featureflags.get_features()["web_1"] is False
+    action = featureflags.reload_feature_flags()
+    assert action is True
+    assert featureflags.get_features()["web_only"] is False
+    assert featureflags.get_features()["web_1"] is True