From 961ac170a9cf4f29a375ccf0a5399bb4359c2ae6 Mon Sep 17 00:00:00 2001 From: QichenZhu <57348009+QichenZhu@users.noreply.github.com> Date: Thu, 16 Jan 2025 22:03:09 +1300 Subject: [PATCH 1/2] Fix pasting in composition mode --- src/MarkdownTextInput.web.tsx | 13 ++++--------- src/web/utils/inputUtils.ts | 4 ++-- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/src/MarkdownTextInput.web.tsx b/src/MarkdownTextInput.web.tsx index 05316223..4b2bb011 100644 --- a/src/MarkdownTextInput.web.tsx +++ b/src/MarkdownTextInput.web.tsx @@ -38,6 +38,8 @@ interface MarkdownTextInputProps extends TextInputProps, InlineImagesInputProps interface MarkdownNativeEvent extends Event { inputType?: string; + isComposing?: boolean; + keyCode?: number; } type MarkdownTextInput = TextInput & React.Component; @@ -120,7 +122,6 @@ const MarkdownTextInput = React.forwardRef(false); const divRef = useRef(null); const currentlyFocusedField = useRef(null); const contentSelection = useRef(null); @@ -370,7 +371,7 @@ const MarkdownTextInput = React.forwardRef { - compositionRef.current = true; - }, []); - const endComposition = useCallback( (e: React.CompositionEvent) => { - compositionRef.current = false; handleOnChangeText(e); }, [handleOnChangeText], @@ -788,7 +784,6 @@ const MarkdownTextInput = React.forwardRef Date: Thu, 16 Jan 2025 23:35:13 +1300 Subject: [PATCH 2/2] Update web-e2e-test.yml --- .github/workflows/web-e2e-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/web-e2e-test.yml b/.github/workflows/web-e2e-test.yml index fb543944..fea3bd9e 100644 --- a/.github/workflows/web-e2e-test.yml +++ b/.github/workflows/web-e2e-test.yml @@ -18,7 +18,7 @@ on: jobs: test: - if: github.repository == 'Expensify/react-native-live-markdown' + if: github.repository == 'QichenZhu/react-native-live-markdown' runs-on: ubuntu-latest concurrency: