Skip to content

Commit e1c7943

Browse files
committed
Keep strategy plugins out of cycle notifications
1 parent 4396ae4 commit e1c7943

3 files changed

Lines changed: 3 additions & 12 deletions

File tree

application/rebalance_service.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
required_semiconductor_rotation_history_lookback,
4646
)
4747
from quant_platform_kit.common.strategy_plugins import (
48-
build_strategy_plugin_notification_lines,
4948
build_strategy_plugin_report_payload,
5049
load_configured_strategy_plugin_signals,
5150
parse_strategy_plugin_mounts,
@@ -198,14 +197,9 @@ def attach_strategy_plugin_result(
198197
error: str | None,
199198
translator: Callable[..., str],
200199
) -> dict[str, Any]:
200+
del translator
201201
if signals:
202202
result.update(build_strategy_plugin_report_payload(signals))
203-
notification_lines = build_strategy_plugin_notification_lines(
204-
signals,
205-
translator=translator,
206-
)
207-
if notification_lines:
208-
result["strategy_plugin_lines"] = notification_lines
209203
if error:
210204
result["strategy_plugin_error"] = error
211205
return result

notifications/telegram.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -635,7 +635,6 @@ def render_cycle_summary(result: Mapping[str, Any], *, lang: str = "en") -> str:
635635
lines.extend(dashboard_lines)
636636
lines.extend(_format_timing_lines(execution, translator=translator))
637637
lines.extend(_format_signal_lines(execution, translator=translator))
638-
lines.extend(str(line).strip() for line in result.get("strategy_plugin_lines") or ())
639638
lines.append(SEPARATOR)
640639
lines.extend(target_diff_lines)
641640
if submitted:

tests/test_rebalance_service.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -278,17 +278,15 @@ def fake_dispatch(signals, **kwargs):
278278
assert result["strategy_plugins"][0]["canonical_route"] == "true_crisis"
279279
assert result["strategy_plugin_alert_email_sent_count"] == 1
280280
assert result["strategy_plugin_alert_sms_sent_count"] == 1
281-
assert result["strategy_plugin_lines"] == (
282-
"🧩 Plugin: Crisis Watch Notice | status: true crisis | notice: defend",
283-
)
281+
assert "strategy_plugin_lines" not in result
284282
assert len(observed_alerts) == 1
285283
assert observed_alerts[0][0][0].canonical_route == "true_crisis"
286284
assert "firstrade" in observed_alerts[0][1]["context_label"]
287285
assert observed_alerts[0][1]["notification_settings"] is settings
288286
assert observed_alerts[0][1]["state_settings"] is not None
289287
assert result["strategy_plugin_alert_email_deliveries"][0]["status"] == "sent"
290288
assert result["strategy_plugin_alert_sms_deliveries"][0]["status"] == "sent"
291-
assert "🧩 Plugin: Crisis Watch Notice | status: true crisis | notice: defend" in messages[0]
289+
assert "🧩 Plugin:" not in messages[0]
292290

293291

294292
def test_run_strategy_cycle_strategy_plugin_load_error_is_non_blocking(monkeypatch):

0 commit comments

Comments
 (0)