Skip to content

Commit d49b3f3

Browse files
authored
Merge pull request #277 from Quantisan/fix/default-jdk-version-tests
Fix default JDK version tests
2 parents 11f2cfb + c1a526b commit d49b3f3

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

bb.edn

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,10 @@
33
org.babashka/spec.alpha {:git/url "https://github.com/babashka/spec.alpha"
44
:git/sha "b6eb0f2208ab036c0a5d0e7235cb0b09d2feabb7"}}
55
:tasks
6-
{:requires ([babashka.deps :as deps]
7-
[docker-clojure.core :as dc])
6+
{:requires ([docker-clojure.core :as dc])
87
clean (dc/-main "clean")
98
dockerfiles {:depends [clean]
109
:task (apply dc/-main "dockerfiles" *command-line-args*)}
1110
manifest (apply dc/-main "manifest" *command-line-args*)
1211
build-images {:task (apply dc/-main "build-images" *command-line-args*)}
13-
test (deref (deps/clojure '-X:test))}}
12+
test (clojure '-X:test)}}

test/docker_clojure/docker_test.clj

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,12 @@
3535
(deftest all-tags-test
3636
(testing "Generates all-defaults tag for a build tool"
3737
(let [tags (all-tags {:base-image "debian"
38-
:jdk-version 21
38+
:jdk-version cfg/default-jdk-version
3939
:distro :debian/bookworm
4040
:build-tool "tools-deps"
4141
:build-tool-version "1.11.1.1155"})]
42-
(is ((set tags) "tools-deps"))))
42+
(is ((set tags) "tools-deps")
43+
(str "Expected \"tools-deps\" to be in " (pr-str tags)))))
4344
(testing "Generates jdk-version-build-tool tag for every jdk version"
4445
(are [jdk-version tag]
4546
(let [tags (all-tags {:base-image (if (< jdk-version 21)
@@ -55,10 +56,10 @@
5556
11 "temurin-11-tools-deps"
5657
17 "temurin-17-tools-deps"
5758
21 "temurin-21-tools-deps"))
58-
(testing "Generates build-tool-distro tag for every distro"
59+
(testing "Generates build-tool-distro tag for every distro with default JDK version"
5960
(are [distro tag]
6061
(let [tags (all-tags {:base-image "debian"
61-
:jdk-version 21
62+
:jdk-version cfg/default-jdk-version
6263
:distro distro
6364
:build-tool "tools-deps"
6465
:build-tool-version "1.11.1.1155"})]

0 commit comments

Comments
 (0)