Even more fixes

Author: kshyatt

.github/workflows/CI.yml

@@ -52,7 +52,9 @@ jobs:
           - os: macos-latest
             group: enzyme/vectorinterface
           - os: macos-latest
-            group: enzyme/indexmanipulations
+            group: enzyme/indexmanipulations/add
+          - os: macos-latest
+            group: enzyme/indexmanipulations/twist_flip_unit
           - os: windows-latest
             group: enzyme/factorizations
           - os: windows-latest
@@ -62,7 +64,9 @@ jobs:
           - os: windows-latest
             group: enzyme/vectorinterface
           - os: windows-latest
-            group: enzyme/indexmanipulations
+            group: enzyme/indexmanipulations/add
+          - os: windows-latest
+            group: enzyme/indexmanipulations/twist_flip_unit
     uses: "QuantumKitHub/QuantumKitHubActions/.github/workflows/Tests.yml@main"
     with:
       group: "${{ matrix.group }}"

ext/TensorKitEnzymeExt/vectorinterface.jl

@@ -54,7 +54,7 @@ function EnzymeRules.reverse(
     Aval = something(cache, A.val)
     Δα = pullback_dα(α, C, Aval)
     !isa(A, Const) && !isa(C, Const) && add!(A.dval, C.dval, conj(α.val))
-    !isa(C, Const) && zerovector!(C.dval)
+    !isa(C, Const) && make_zero!(C.dval)
     return (nothing, nothing, Δα)
 end
 

test/enzyme/vectorinterface/inner.jl

@@ -35,13 +35,12 @@ eltypes = (Float64, ComplexF64)
 
 @testset "Enzyme - VectorInterface" begin
     @timedtestset "$(TensorKit.type_repr(sectortype(eltype(V)))) ($T)" for V in spacelist, T in eltypes
-        atol = default_tol(T)
-        rtol = default_tol(T)
-        C = randn(T, V[1] ⊗ V[2] ← V[3] ⊗ V[4] ⊗ V[5])
-        A = randn(T, V[1] ⊗ V[2] ← V[3] ⊗ V[4] ⊗ V[5])
-        @testset for RT in (Active,), TC in (Duplicated, Const), TA in (Duplicated, Const)
-            EnzymeTestUtils.test_reverse(inner, RT, (C, TC), (A, TA); atol, rtol)
-            EnzymeTestUtils.test_reverse(inner, RT, (C', TC), (A', TA); atol, rtol)
+        @testset for RT in (Active,), TC in (Duplicated, Const), TA in (Duplicated, Const), f in (identity, adjoint)
+            atol = default_tol(T)
+            rtol = default_tol(T)
+            C = randn(T, V[1] ⊗ V[2] ← V[3] ⊗ V[4] ⊗ V[5])
+            A = randn(T, V[1] ⊗ V[2] ← V[3] ⊗ V[4] ⊗ V[5])
+            EnzymeTestUtils.test_reverse(inner, RT, (f(C), TC), (f(A), TA); atol, rtol)
         end
     end
 end

test/enzyme/vectorinterface/scale.jl

@@ -37,17 +37,16 @@ eltypes = (Float64, ComplexF64)
     @timedtestset "$(TensorKit.type_repr(sectortype(eltype(V)))) ($T)" for V in spacelist, T in eltypes
         atol = default_tol(T)
         rtol = default_tol(T)
-        C = randn(T, V[1] ⊗ V[2] ← V[3] ⊗ V[4] ⊗ V[5])
-        A = randn(T, V[1] ⊗ V[2] ← V[3] ⊗ V[4] ⊗ V[5])
         α = randn(T)
         @testset for TC in (Duplicated,), Tα in (Active, Const)
+            C = randn(T, V[1] ⊗ V[2] ← V[3] ⊗ V[4] ⊗ V[5])
             EnzymeTestUtils.test_reverse(scale!, TC, (C, TC), (α, Tα); atol, rtol)
+            C = randn(T, V[1] ⊗ V[2] ← V[3] ⊗ V[4] ⊗ V[5])
             EnzymeTestUtils.test_reverse(scale!, TC, (C', TC), (α, Tα); atol, rtol)
-            @testset for TA in (Duplicated,)
-                EnzymeTestUtils.test_reverse(scale!, TC, (C, TC), (A, TA), (α, Tα); atol, rtol)
-                EnzymeTestUtils.test_reverse(scale!, TC, (C', TC), (A', TA), (α, Tα); atol, rtol)
-                EnzymeTestUtils.test_reverse(scale!, TC, (copy(C'), TC), (A', TA), (α, Tα); atol, rtol)
-                EnzymeTestUtils.test_reverse(scale!, TC, (C', TC), (copy(A'), TA), (α, Tα); atol, rtol)
+            @testset for TA in (Duplicated,), (fc, fa) in ((identity, identity), (adjoint, adjoint))
+                C = randn(T, V[1] ⊗ V[2] ← V[3] ⊗ V[4] ⊗ V[5])
+                A = randn(T, V[1] ⊗ V[2] ← V[3] ⊗ V[4] ⊗ V[5])
+                EnzymeTestUtils.test_reverse(scale!, TC, (fc(C), TC), (fa(A), TA), (α, Tα); atol, rtol)
             end
         end
     end