Skip to content
This repository was archived by the owner on Oct 10, 2025. It is now read-only.

Commit 3ee23d2

Browse files
committed
Fix files tests
1 parent e071a5c commit 3ee23d2

2 files changed

Lines changed: 13 additions & 9 deletions

File tree

src/files.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ pub struct FileInfo {
2020
pub async fn list_files(event_id: EventId, state: &State<SharedQxState>) -> Result<Vec<FileInfo>, Custom<String>> {
2121
println!("listing files of event: {event_id}");
2222
let edb = get_event_db(event_id, state).await.map_err(anyhow_to_custom_error)?;
23-
let files = sqlx::query_as::<_, FileInfo>("SELECT id, name, LENGTH(data) AS size, created FROM files")
23+
let files = sqlx::query_as::<_, FileInfo>("SELECT id, name, LENGTH(data) AS size, created FROM files ORDER BY name")
2424
.fetch_all(&edb).await.map_err(sqlx_to_custom_error)?;
2525
Ok(files)
2626
}

src/tests.rs

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ use crate::event::{EventId, EventRecord, PostedEvent};
77
use crate::files::FileInfo;
88
use crate::qxdatetime::QxDateTime;
99
use crate::{util};
10-
use crate::qx::QxRunChange;
10+
use crate::changes::QxRunChange;
1111
use crate::runs::RunsRecord;
1212

1313
const API_TOKEN: &str = "plelababamak";
@@ -63,29 +63,27 @@ fn upload_file() {
6363

6464
// send file
6565
let file_name = "a.txt";
66-
let orig = b"foo-bar-baz";
67-
let compressed = util::test::zip_data(orig).unwrap();
66+
let data = b"foo-bar-baz";
67+
let compressed_data = util::test::zip_data(data).unwrap();
6868
let resp = client.post(format!("/api/event/current/file?name={file_name}"))
6969
.header(Header::new("qx-api-token", API_TOKEN))
7070
.header(ContentType::ZIP)
71-
.body(compressed)
71+
.body(compressed_data)
7272
.dispatch();
7373
assert_eq!(resp.status(), Status::Ok);
7474
let file_id = resp.into_string().unwrap().parse::<i32>().unwrap();
75-
assert_eq!(file_id, 1);
7675

7776
// get this file
7877
let resp = client.get(format!("/api/event/{EVENT_ID}/file/{file_id}")).dispatch();
7978
assert_eq!(resp.status(), Status::Ok);
8079
let content = resp.into_bytes().unwrap();
81-
assert_eq!(&content, orig);
80+
assert_eq!(&content, data);
8281

8382
// list files
8483
let resp = client.get(format!("/api/event/{EVENT_ID}/file")).dispatch();
8584
assert_eq!(resp.status(), Status::Ok);
8685
let files = resp.into_json::<Vec<FileInfo>>().unwrap();
87-
assert_eq!(files.iter().len(), 1);
88-
assert_eq!(&files.first().unwrap().name, file_name);
86+
assert!(files.iter().find(|f| f.name == file_name).is_some());
8987

9088
//delete not existing file
9189
let resp = client.delete(format!("/api/event/{EVENT_ID}/file/42")).dispatch();
@@ -97,6 +95,12 @@ fn upload_file() {
9795
//delete existing file
9896
let resp = client.delete(format!("/api/event/{EVENT_ID}/file/{file_id}")).dispatch();
9997
assert_eq!(resp.status(), Status::Ok);
98+
99+
// list files
100+
let resp = client.get(format!("/api/event/{EVENT_ID}/file")).dispatch();
101+
assert_eq!(resp.status(), Status::Ok);
102+
let files = resp.into_json::<Vec<FileInfo>>().unwrap();
103+
assert!(files.iter().find(|f| f.name == file_name).is_none());
100104
}
101105

102106
fn upload_start_list_impl(client: &Client) {

0 commit comments

Comments
 (0)