Wire up phpstan

Author: donatj

.github/workflows/ci.yml

@@ -11,7 +11,7 @@ jobs:
     strategy:
       matrix:
         operating-system: [ubuntu-latest]
-        php-versions: ['7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5']
+        php-versions: ['7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5']
 
     runs-on: ${{ matrix.operating-system }}
 

Makefile

@@ -7,8 +7,12 @@ README.md: $(SRC_FILES)
 fix: cbf
 	vendor/bin/php-cs-fixer fix
 
+.PHONY: phpstan
+phpstan:
+	vendor/bin/phpstan --memory-limit=2G
+
 .PHONY: test
-test: cs
+test: cs phpstan
 	vendor/bin/phpunit
 
 .PHONY: cs
@@ -17,4 +21,4 @@ cs:
 
 .PHONY: cbf
 cbf:
-	vendor/bin/phpcbf
+	vendor/bin/phpcbf

composer.json

@@ -3,13 +3,14 @@
 	"description": "Simple PHP Dot Notation Parser",
 	"type": "library",
 	"require": {
-		"php": ">=7.1"
+		"php": ">=7.4"
 	},
 	"require-dev": {
 		"phpunit/phpunit": "~7.5 | ~9.5",
 		"squizlabs/php_codesniffer": "^3.5",
 		"corpus/coding-standard": "~0.6.0",
-		"friendsofphp/php-cs-fixer": "^2.17"
+		"friendsofphp/php-cs-fixer": "^2.17",
+		"phpstan/phpstan": "^2.1"
 	},
 	"license": "MIT",
 	"authors": [

phpstan.neon

@@ -0,0 +1,4 @@
+parameters:
+	level: max
+	paths:
+		- src

src/DotNotationParser.php

@@ -82,9 +82,11 @@ private function scanQuotedString( \Iterator $chars ) : string {
 		$buff = '';
 
 		$chars->next();
+		/** @var int|null $lastKey */
 		$lastKey = $chars->key();
 		for(;;) {
 			$token = $chars->current();
+			/** @var int|null $key */
 			$key   = $chars->key();
 
 			if( !$chars->valid() ) {
@@ -98,6 +100,7 @@ private function scanQuotedString( \Iterator $chars ) : string {
 			if( $token === '"' ) {
 				$chars->next();
 				$next    = $chars->current();
+				/** @var int|null $nextKey */
 				$nextKey = $chars->key();
 
 				if( !$chars->valid() || $next === '.' ) {
@@ -107,7 +110,7 @@ private function scanQuotedString( \Iterator $chars ) : string {
 
 				throw new ParseException(
 					sprintf('failed to parse path, expected . or EOF, got "%s" at %d', $next, $key),
-					$nextKey ?? $key,
+					$nextKey ?? $key ?? ($lastKey + 1),
 					ParseException::CODE_UNEXPECTED_CHARACTER
 				);
 			}