Skip to content

Commit d553972

Browse files
Fix test-coverage.yaml timeout caused by incorrect boolean expression (#45)
* Initial plan * Fix fail_ci_if_error boolean expression in test-coverage.yaml Changed the expression from checking secrets.CODECOV_TOKEN (which returns the token string) to properly checking if it's not empty with != ''. This ensures the parameter receives a proper boolean value instead of a truthy string. Co-authored-by: smasongarrison <6001608+smasongarrison@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: smasongarrison <6001608+smasongarrison@users.noreply.github.com>
1 parent 8b51252 commit d553972

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/workflows/test-coverage.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
- uses: codecov/codecov-action@v4
4141
with:
4242
# Fail if error if not on PR, or if on PR and token is given
43-
fail_ci_if_error: ${{ github.event_name != 'pull_request' || secrets.CODECOV_TOKEN }}
43+
fail_ci_if_error: ${{ github.event_name != 'pull_request' || secrets.CODECOV_TOKEN != '' }}
4444
file: ./cobertura.xml
4545
plugin: noop
4646
disable_search: true

0 commit comments

Comments
 (0)