Remove per-scope client settings

Author: savvan0h

xapi_stmt_gen/xapi_stmt_gen/config/app.js

@@ -21,29 +21,13 @@ const config = {
     }
   },
   LRS:{
-    clients:{
-      // LRS client
-      'default':{
-        user:'031eb8dccd9729d6a8a16d245b4d1dddf1e2ded7',
-        pass:'a94fd8e44662fe7cd50cd53812dad84a4a81ab9b'
-      },
-      /**
-       * This 'scoped' setting can be used to send
-       * statements to separated LRSes based on ePPN in GakuNin.
-       */
-      //'scoped':[
-      //  {
-      //    scope:'foo.co.jp',
-      //    user:'dc052567a686bb93a7e2fb9547ed6f6974171e8b',
-      //    pass:'b0a3f0e04294c258cb3ce8bdbb55d24c6bad15f8'
-      //  },
-      //  {
-      //    scope:'bar.ac.jp',
-      //    user:'74abe7278e28aef9b5548d90700ee423e36c1fbb',
-      //    pass:'8a34c7f8433d51ede87f533afe672d6e357c8d37'
-      //  }
-      //]
-    }
+    // LRS client with 'Overall Scopes: API All' checked
+    client:{
+      key:'',
+      secret:''
+    },
+    // Store statements in each LRS with title matching actor's ePPN scope
+    ePPNScoped:false,
   },
   category:{
     id:'http://moodle.org',

xapi_stmt_gen/xapi_stmt_gen/generator.js

@@ -1017,40 +1017,48 @@ async function sendStatements(statements, lrs) {
   });
 }
 
-/**
- * Checks if LRSes are scoped.
- */
-function isScoped() {
-  if ('scoped' in config.LRS.clients) {
-    return true;
-  }
-  return false;
-}
+let LRS_CLIENTS;
 
 /**
- * Returns LRS settings found by scope.
+ * Returns LRS clients.
  */
-function getLRS(scope) {
-  let lrses = {};
-  if ('default' in config.LRS.clients) {
-    lrses['default'] = {
-      'auth':{
-        'username':config.LRS.clients.default.user,
-        'password':config.LRS.clients.default.pass
-      },
-    };
-  }
-  if ('scoped' in config.LRS.clients) {
-    config.LRS.clients.scoped.forEach(client => {
-      lrses[client.scope] = {
-        'auth':{
-          'username':client.user,
-          'password':client.pass
-        },
-      };
-    });
+async function getLRSClients() {
+  if (!(config.LRS.client.key && config.LRS.client.secret)) {
+    process.exitCode = 1;
+    throw new Error('Specify LRS client in config/app.js');
   }
-  return lrses[scope];
+  const clientResponse = await axios.get(`${config.url}:3000/api/v2/client`, {
+    'auth': {
+      'username':config.LRS.client.key,
+      'password':config.LRS.client.secret
+    }
+  }).catch(err => {
+    process.exitCode = 1;
+    throw new Error(`Failed to get LRS clients - ${err}`);
+  });
+  const lrsResponse = await axios.get(`${config.url}:3000/api/v2/lrs`, {
+    'auth': {
+      'username':config.LRS.client.key,
+      'password':config.LRS.client.secret
+    }
+  }).catch(err => {
+    process.exitCode = 1;
+    throw new Error(`Failed to get LRSes - ${err}`);
+  });
+  let clients = {}
+  lrsResponse.data.forEach((lrs) => {
+    const client = clientResponse.data.find(c => c.lrs_id === lrs._id)
+    const key = client.api.basic_key
+    const secret = client.api.basic_secret
+    const scope = (key === config.LRS.client.key && secret === config.LRS.client.secret) ? 'default' : lrs.title
+    clients[scope] = {
+      'auth': {
+        'username': key,
+        'password': secret
+      }
+    };
+  });
+  return clients;
 }
 
 /**
@@ -1067,7 +1075,7 @@ async function routeStatements(objecttable, xapis){
     const statements = xapis[scope].map((value, index, array) => {
       return value.statement;
     });
-    const lrs = getLRS(scope);
+    const lrs = LRS_CLIENTS[scope];
     const seq = objectids[0];
     logger.info(
       `[SEQ:${seq}][SCOPE:${scope}] Sending ${statements.length} statements...`
@@ -1109,15 +1117,15 @@ function getScopeFromEppn(username) {
  */
 function getLRSScope(userAttrs, userid) {
   let scope = 'default';
-  if (isScoped()) {
+  if (config.LRS.ePPNScoped) {
     scope = userid in userAttrs ? userAttrs[userid].scope : null;
     if (!scope) {
       logger.trace(
         `The user(id:${userid}) doesn't have ` +
         'an ePPN scope, sending the statement to the default LRS.'
       );
       scope = 'default';
-    } else if (!getLRS(scope)) {
+    } else if (!LRS_CLIENTS[scope]) {
       logger.trace(
         `LRS for ${scope} not found, ` +
         'sending the statement to the default LRS.'
@@ -3417,6 +3425,7 @@ async function translateStandardLogs(logs, userAttrs, courseNames){ // eslint-di
         );
         continue;
     }
+
     const scope = getLRSScope(userAttrs, log.userid);
     if (!(scope in xapis)) {
       xapis[scope] = [];
@@ -3683,10 +3692,7 @@ const waitForInterval = () => {
  * Processes logs until no more data exists.
  */
 module.exports = async function main() { // eslint-disable-line max-statements
-  if (!('default' in config.LRS.clients) && !('scoped' in config.LRS.clients)) {
-    process.exitCode = 1;
-    throw new Error('Specify LRS clients in config/app.js');
-  }
+  LRS_CLIENTS = await getLRSClients();
 
   // Retrieve all users
   const users = await USER.findAll({