Skip to content

Commit b6cdae5

Browse files
Old-DingRbb666
authored andcommitted
net: lwip: fix mDNS test buffer fill size
Fill the mDNS domain name buffers with their array size instead of the size of the MDNS_DOMAIN_MAXLEN constant. This preserves the test intent of leaving different trailing bytes after equal names are encoded. Generated-by: OpenAI Codex Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
1 parent 247f540 commit b6cdae5

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

components/net/lwip/lwip-2.0.3/test/unit/mdns/test_mdns.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -572,14 +572,14 @@ START_TEST(domain_eq_length)
572572
LWIP_UNUSED_ARG(_i);
573573

574574
memset(&domain1, 0, sizeof(domain1));
575-
memset(domain1.name, 0xAA, sizeof(MDNS_DOMAIN_MAXLEN));
575+
memset(domain1.name, 0xAA, sizeof(domain1.name));
576576
res = mdns_domain_add_label(&domain1, "multi", 5);
577577
fail_unless(res == ERR_OK);
578578
res = mdns_domain_add_label(&domain1, "cast", 4);
579579
fail_unless(res == ERR_OK);
580580

581581
memset(&domain2, 0, sizeof(domain2));
582-
memset(domain2.name, 0xBB, sizeof(MDNS_DOMAIN_MAXLEN));
582+
memset(domain2.name, 0xBB, sizeof(domain2.name));
583583
res = mdns_domain_add_label(&domain2, "multi", 5);
584584
fail_unless(res == ERR_OK);
585585
res = mdns_domain_add_label(&domain2, "cast", 4);

components/net/lwip/lwip-2.1.2/test/unit/mdns/test_mdns.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -572,14 +572,14 @@ START_TEST(domain_eq_length)
572572
LWIP_UNUSED_ARG(_i);
573573

574574
memset(&domain1, 0, sizeof(domain1));
575-
memset(domain1.name, 0xAA, sizeof(MDNS_DOMAIN_MAXLEN));
575+
memset(domain1.name, 0xAA, sizeof(domain1.name));
576576
res = mdns_domain_add_label(&domain1, "multi", 5);
577577
fail_unless(res == ERR_OK);
578578
res = mdns_domain_add_label(&domain1, "cast", 4);
579579
fail_unless(res == ERR_OK);
580580

581581
memset(&domain2, 0, sizeof(domain2));
582-
memset(domain2.name, 0xBB, sizeof(MDNS_DOMAIN_MAXLEN));
582+
memset(domain2.name, 0xBB, sizeof(domain2.name));
583583
res = mdns_domain_add_label(&domain2, "multi", 5);
584584
fail_unless(res == ERR_OK);
585585
res = mdns_domain_add_label(&domain2, "cast", 4);

0 commit comments

Comments
 (0)