Skip to content

Commit 9b9a0a2

Browse files
bschilderclaude
andcommitted
Fix GHA: remove XGR from Remotes, fix NOTT2019 seqnames bug
- Remove XGR from Remotes (dnet/supraHex unavailable on Bioc devel). XGR remains in Suggests with requireNamespace() guards. - Fix NOTT2019_get_interactions: use "seqnames" as chrom_col in dt_to_granges (GRanges→data.frame renames CHR to seqnames). - Add "aut" role to maintainer in DESCRIPTION. - Bump version to 1.0.1. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 2e29840 commit 9b9a0a2

3 files changed

Lines changed: 15 additions & 7 deletions

File tree

DESCRIPTION

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
Package: echoannot
22
Type: Package
33
Title: Echoverse Module: Annotate Fine-Mapping Results
4-
Version: 1.0.0
4+
Version: 1.0.1
55
Date: 2026-03-08
66
Authors@R:
77
c(person(given = "Brian",
88
family = "Schilder",
9-
role = c("cre"),
9+
role = c("aut","cre"),
1010
email = "brian_schilder@alumni.brown.edu",
1111
comment = c(ORCID = "0000-0001-5949-2191")),
1212
person(given = "Jack",
@@ -77,8 +77,7 @@ Suggests:
7777
Remotes:
7878
github::RajLabMSSM/echodata,
7979
github::RajLabMSSM/echotabix,
80-
github::RajLabMSSM/downloadR,
81-
github::hfang-bristol/XGR
80+
github::RajLabMSSM/downloadR
8281
RoxygenNote: 7.3.3
8382
VignetteBuilder: knitr
8483
License: GPL-3

NEWS.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
# echoannot 1.0.1
2+
3+
## Bug fixes
4+
5+
* Remove XGR from Remotes to fix GHA dependency installation failure
6+
(`dnet`/`supraHex` unavailable on Bioconductor devel). XGR remains
7+
in Suggests with `requireNamespace()` guards.
8+
* Add `"aut"` role to maintainer in DESCRIPTION (required by `--as-cran`).
9+
110
# echoannot 1.0.0
211

312
## New features

R/NOTT2019_get_interactions.R

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,13 +72,13 @@ NOTT2019_get_interactions <- function(dat,
7272

7373
if (as_granges) {
7474
interactomes.anchor <- echodata::dt_to_granges(
75-
dat = interactomes.anchor |> dplyr::select(-seqnames),
76-
chrom_col = "CHR",
75+
dat = interactomes.anchor,
76+
chrom_col = "seqnames",
7777
start_col = "start",
7878
end_col = "end",
7979
style = "NCBI",
8080
verbose = verbose
81-
)
81+
)
8282
}
8383
return(interactomes.anchor)
8484
}

0 commit comments

Comments
 (0)