Immediate: users should be able to disable push notifications

Author: gvbvdxxalt2

server-src/server.js

@@ -2933,7 +2933,7 @@ const server = http.createServer(async function (req, res) {
         return;
       }
 
-      if (typeof json.endpoint == "string") {
+      if (typeof json.endpoint !== "string") {
         res.statusCode = 401;
         res.end("Endpoint is invalid type.");
         return;

src/accounthelper/index.js

@@ -169,7 +169,9 @@ async function uploadPushSubscription(subscription) {
 async function uploadRemovePushSubscription(subscription) {
   var response = await fetch(getServerURL() + "/webpush/unsubscribe", {
     method: "POST",
-    body: JSON.stringify(subscription),
+    body: JSON.stringify({
+      endpoint: subscription.endpoint
+    }),
     headers: { "Content-Type": "application/json" },
   });
   if (!response.ok) {
@@ -195,8 +197,8 @@ pushNotificationHelper.unsubscribe = async function () {
   if (!subscription) {
     return; //No subscription
   }
-  await pushNotificationHelper.__unsubscribe();
   await uploadRemovePushSubscription(subscription);
+  await pushNotificationHelper.__unsubscribe();
 };
 
 module.exports = {

src/chat/interface/notifications/index.js

@@ -214,6 +214,7 @@ class RealTimeNotifications {
           event: "click",
           func: function () {
             _this.dialogElement.hidden = false;
+            _this.loadNotifications();
           },
         },
       ],

wpstatic/version.json

@@ -1 +1 @@
-{"timestamp":"1770739203980"}
+{"timestamp":"1770740200809"}