Immediate: fix annoying bug that causes cameras and microphones to stay visible to other users.

Author: gvbvdxxalt2

server-src/server.js

@@ -2275,6 +2275,21 @@ async function startRoomWSS(roomid) {
       }
       wss._rrPeopleCount += 1;
       ws.on("close", () => {
+        wss.clients.forEach((cli) => {
+            if (!cli._rrIsReady) {
+              return;
+            }
+            cli.send(
+              JSON.stringify({
+                type: "userLeft",
+                username: ws._rrUsername,
+                displayName: displayName,
+                color: ws._rrUserColor,
+                font: ws._rrUserFont,
+                id: ws._rrConnectionID,
+              }),
+            );
+          });
         clearTimeout(ws._rrkeepAliveTimeout);
         clearInterval(roomCheckInterval);
         wss._rrPeopleCount -= 1;

src/chat/interface/chatinterface.js

@@ -453,6 +453,10 @@ require("./darktheme.js");
             microphones.end(json.id);
           }
         }
+        if (json.type == "userLeft") {
+          microphones.end(json.id);
+          cameras.hide(json.id);
+        }
         if (json.type == "ready") {
           loadingScreen.hidden = true;
           mainScreen.hidden = false;

src/chat/interface/microphones.js

@@ -96,14 +96,7 @@ microphones.end = function (id) {
     //Dispose of the userMicrophone.
     userMicrophones[id] = undefined;
 
-    //Just to make sure its actually disposed, filter out any empty values in userMicrophones.
-    var newObjects = {};
-    for (var id of Object.keys(userMicrophones)) {
-      if (userMicrophones[id]) {
-        newObjects[id] = userMicrophones[id];
-      }
-    }
-    userMicrophones = newObjects;
+    delete userMicrophones[id];
   }
 };
 

src/chat/interface/notify.js

@@ -10,21 +10,31 @@ notify.requestPermission = async function () {
   } catch (e) {}
 };
 
-notify.sendIfNotOnScreen = function (tag, message, title = "Random Rants +") {
-  if (!asked) {
-    return;
-  }
+notify.sendIfNotOnScreen = function (tag, body, title = "Random Rants +") {
   if (document.visibilityState !== "visible") {
     if (lastNotifcation) {
       try {
         lastNotifcation.close();
       } catch (e) {}
     }
-    lastNotifcation = new Notification(title, {
-      icon: "favicon.png",
-      tag: tag,
-      body: message,
-    });
+    try {
+      if ("serviceWorker" in navigator && navigator.serviceWorker.controller) {
+        navigator.serviceWorker.controller.postMessage({
+          type: "NOTIFY",
+          payload: {
+            title,
+            body,
+            tag,
+          },
+        });
+      } else {
+        lastNotifcation = new Notification(title, {
+          icon: "favicon.png",
+          tag: tag,
+          body: message,
+        });
+      }
+    } catch (e) {}
   }
 };
 

src/serviceworker/index.js

@@ -155,6 +155,8 @@ self.addEventListener("message", async (event) => {
     var cache = await caches.open("rr-meta");
     // Save the current timestamp
     await cache.put("last-seen-online", new Response(Date.now().toString()));
+  } else if (event.data && event.data.type === "NOTIFY") {
+    await sendPushNotification(event.data.payload);
   }
 });
 

wpstatic/version.json

@@ -1 +1 @@
-{"timestamp":"1770818041777"}
+{"timestamp":"1770907394595"}