Add notification sound

Author: gvbvdxx

src/chat/interface/chatinterface.js

@@ -540,8 +540,9 @@ var clientSettings = require("./clientsettings.js");
           }
           if (clientSettings.getSetting("CHAT_NOTIFY")) {
             notify.sendIfNotOnScreen(
-              "New message!",
-              `${json.displayName}: ${shtml.bracketCodeRemoval(json.message)}`
+              "New message",
+              `${json.displayName}: ${shtml.bracketCodeRemoval(json.message)}`,
+              "New message"
             );
           }
         }

src/chat/interface/commands/index.js

@@ -608,4 +608,10 @@ com.importantMessage = function (messageText) {
   }, 10000);
 };
 
+com.cheeseStorm = function () {
+  if (!clientSettings.getSetting("JOKE_COMMANDS")) {
+    return;
+  }
+};
+
 module.exports = com;

src/chat/interface/notifications/index.js

@@ -2,6 +2,7 @@ var elements = require("../../../gp2/elements.js");
 var dialogs = require("../../../dialogs.js");
 var sws = require("../sharedwebsocket.js");
 var audio = require("../../../audio.js");
+var sounds = require("../sounds.js");
 var clientSettings = require("../clientsettings.js");
 var accountHelper = require("../../../accounthelper/index.js");
 var notify = require("../notify.js");
@@ -81,7 +82,7 @@ class RealTimeNotifications {
                   {
                     element: "p",
                     textContent:
-                      "You'll recive notifications actions such as invites to people from other rooms.",
+                      "You'll recive notifications here from certain things, such as invites to chatrooms.",
                   },
                   {
                     element: "p",
@@ -228,23 +229,31 @@ class RealTimeNotifications {
         this.notifications = this.notifications.slice(-100);
         this.loadNotifications();
         var notification = json.notification;
+        if (clientSettings.getSetting("UI_SOUNDS")) {
+          sounds.play("notificationBell", 1);
+        }
         if (
           notification.type == "test" &&
           clientSettings.getSetting("BELL_NOTIFCATIONS")
         ) {
-          notify.sendIfNotOnScreen("notification", "Test notification");
+          notify.sendIfNotOnScreen(
+            "Testing",
+            "Test notification",
+            "New notification received"
+          );
         }
         if (
           notification.type == "invite" &&
           clientSettings.getSetting("BELL_NOTIFCATIONS")
         ) {
           notify.sendIfNotOnScreen(
-            "notification",
+            "Chatroom Invitation",
             "@" +
               notification.from +
               ' has invited you to the chat room "' +
               notification.roomName +
-              '"'
+              '"',
+            "Invited to " + notification.roomName
           );
         }
       }

src/chat/interface/notifications/invitenotifcation.js

@@ -6,14 +6,14 @@ var notify = {};
 
 var lastNotifcation = null;
 
-notify.sendIfNotOnScreen = function (tag, message) {
+notify.sendIfNotOnScreen = function (tag, message, title = "Random Rants +") {
   if (document.visibilityState !== "visible") {
     if (lastNotifcation) {
       try {
         lastNotifcation.close();
       } catch (e) {}
     }
-    lastNotifcation = new Notification("Random Rants +", {
+    lastNotifcation = new Notification(title, {
       icon: "favicon.png",
       tag: tag,
       body: message,

src/chat/interface/notify.js

@@ -24,19 +24,21 @@ soundManager.load = async function () {
   var a = await fetch("external/uisound.json");
   var soundURLS = await a.json();
 
-  var soundsToLoad = ["error", "notify", "type", "select"];
+  var soundsToLoad = ["error", "notify", "type", "select", "notificationBell"];
 
   for (var soundName of soundsToLoad) {
     var data;
     data = await audio.loadSoundFromURL(soundURLS[soundName]);
     //loadSoundFromURL may fail and return null without throwing errors.
     //although no errors would be thrown trying to play null, it would lead to unexpected bugs
     if (!data) {
-      data = await audio.loadSoundFromURL(soundURLS[soundName + "Backup"]);
+      if (soundURLS[soundName + "Backup"]) {
+        data = await audio.loadSoundFromURL(soundURLS[soundName + "Backup"]);
+      }
     }
     if (!data) {
       console.warn(
-        `❌ UI sound "${soundName}" failed to load from both primary and backup.`,
+        `❌ UI sound "${soundName}" failed to load from both primary and backup. (if provided)`
       );
     }
     sounds[soundName] = data;

src/chat/interface/sounds.js

@@ -7,5 +7,7 @@
   "errorBackup": "uisounds/error.mp3",
   "notifyBackup": "uisounds/pop.mp3",
   "selectBackup": "uisounds/select.mp3",
-  "typeBackup": "uisounds/keyboard.mp3"
+  "typeBackup": "uisounds/keyboard.mp3",
+
+  "notificationBell": "uisounds/notification.wav"
 }

wpstatic/external/uisound.json

@@ -1 +1 @@
-{"timestamp":"1761232736672"}
+{"timestamp":"1761234814866"}