Create read endpoint, add functionality

Author: jamiebenstead

app/controllers/api/feedback_controller.rb

@@ -30,6 +30,18 @@ def create
       end
     end
 
+    def set_read
+      feedback = Feedback.find(params[:id])
+      result = Feedback::SetRead.call(feedback: feedback)
+
+      if result.success?
+        @feedback = result[:feedback]
+        render :show, formats: [:json], status: :ok
+      else
+        render json: { error: result[:error] }, status: :unprocessable_entity
+      end
+    end
+
     private
 
     def project
@@ -68,8 +80,8 @@ def feedback_create_params
     end
 
     def url_params
-      permitted_params = params.permit(:project_id)
-      { identifier: permitted_params[:project_id] }
+      permitted_params = params.permit(:project_id, :id)
+      { identifier: permitted_params[:project_id], id: permitted_params[:id] }
     end
 
     def base_params

app/models/ability.rb

@@ -113,7 +113,7 @@ def define_school_student_abilities(user:, school:)
     can(%i[read], Lesson, school_id: school.id, visibility: 'students', school_class: { students: { student_id: user.id } })
     can(%i[read create update], Project, school_id: school.id, user_id: user.id, lesson_id: nil, remixed_from_id: visible_lesson_project_ids)
     can(%i[read show_context], Project, lesson: { school_id: school.id, visibility: 'students', school_class: { students: { student_id: user.id } } })
-    can(%i[read], Feedback, school_project: { project: { school_id: school.id, user_id: user.id, lesson_id: nil, remixed_from_id: visible_lesson_project_ids } })
+    can(%i[read set_read], Feedback, school_project: { project: { school_id: school.id, user_id: user.id, lesson_id: nil, remixed_from_id: visible_lesson_project_ids } })
     can(%i[show_finished set_finished show_status unsubmit submit], SchoolProject, project: { user_id: user.id, lesson_id: nil }, school_id: school.id)
   end
 

app/views/api/feedback/_feedback.json.jbuilder

@@ -7,5 +7,6 @@ json.call(
   :user_id,
   :content,
   :created_at,
-  :updated_at
+  :updated_at,
+  :read_at
 )

config/routes.rb

@@ -46,7 +46,9 @@
       resource :remix, only: %i[show create], controller: 'projects/remixes'
       resources :remixes, only: %i[index], controller: 'projects/remixes'
       resource :images, only: %i[show create], controller: 'projects/images'
-      resources :feedback, only: %i[index create], controller: 'feedback'
+      resources :feedback, only: %i[index create], controller: 'feedback' do
+        put :read, on: :member, to: 'feedback#set_read'
+      end
     end
 
     resource :project_errors, only: %i[create]

lib/concepts/feedback/set_read.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+class Feedback
+  class SetRead
+    class << self
+      def call(feedback:)
+        response = OperationResponse.new
+        response[:feedback] = feedback
+        response[:feedback].read_at = Time.current
+        response[:feedback].save!
+        response
+      rescue StandardError => e
+        Sentry.capture_exception(e)
+        response[:error] = response[:feedback]&.errors
+        response
+      end
+    end
+  end
+end