Add back in validate wrapped in feature flag, add tests

Author: jamiebenstead

app/models/teacher_invitation.rb

@@ -6,6 +6,7 @@ class TeacherInvitation < ApplicationRecord
   belongs_to :school
   validates :email_address,
             format: { with: EmailValidator.regexp, message: I18n.t('validations.invitation.email_address') }
+  validate :school_is_verified, unless: -> { FeatureFlags.immediate_school_onboarding? }
   after_create_commit :send_invitation_email
   encrypts :email_address
 
@@ -15,6 +16,12 @@ class TeacherInvitation < ApplicationRecord
 
   private
 
+  def school_is_verified
+    return if school.verified?
+
+    errors.add(:school, 'is not verified')
+  end
+
   def send_invitation_email
     InvitationMailer.with(invitation: self).invite_teacher.deliver_later
   end

lib/concepts/school_student/create.rb

@@ -22,18 +22,26 @@ def create_student(school, school_student_params, token)
         password = DecryptionHelpers.decrypt_password(encrypted_password)
         name = school_student_params.fetch(:name)
 
-        validate(username:, password:, name:)
+        validate(
+          username:,
+          password:,
+          name:,
+          school: (FeatureFlags.immediate_school_onboarding? ? nil : school)
+        )
 
         response = ProfileApiClient.create_school_student(token:, username:, password:, name:, school_id:)
         user_id = response[:created].first
         Role.student.create!(school:, user_id:)
         user_id
       end
 
-      def validate(username:, password:, name:)
+      def validate(username:, password:, name:, school: nil)
         raise ArgumentError, "username '#{username}' is invalid" if username.blank?
         raise ArgumentError, "password '#{password}' is invalid" if password.size < 8
         raise ArgumentError, "name '#{name}' is invalid" if name.blank?
+
+        return unless school
+        raise ArgumentError, 'school must be verified' unless school.verified?
       end
     end
   end

spec/concepts/school_student/create_spec.rb

@@ -76,6 +76,29 @@
     end
   end
 
+  context 'when the school is not verified' do
+    let(:school) { create(:school) } # not verified by default
+
+    context 'when immediate_school_onboarding is FALSE' do
+      it 'returns the error message in the operation response' do
+        ClimateControl.modify(ENABLE_IMMEDIATE_SCHOOL_ONBOARDING: 'false') do
+          response = described_class.call(school:, school_student_params:, token:)
+          expect(response[:error]).to match(/school must be verified/)
+        end
+      end
+    end
+
+    context 'when immediate_school_onboarding is TRUE' do
+      it 'does not error due to school verification' do
+        ClimateControl.modify(ENABLE_IMMEDIATE_SCHOOL_ONBOARDING: 'true') do
+          response = described_class.call(school:, school_student_params:, token:)
+
+          expect(response[:error]).to be_nil
+        end
+      end
+    end
+  end
+
   context 'when the student cannot be created in profile api because of a 422 response' do
     let(:error) { { 'message' => "something's up with the username" } }
     let(:exception) { ProfileApiClient::Student422Error.new(error) }

spec/concepts/school_teacher/invite_spec.rb

@@ -53,9 +53,26 @@
   context 'when the school is not verified' do
     let(:school) { create(:school) }
 
-    it 'does not return an error message in the operation response' do
-      response = described_class.call(school:, school_teacher_params:, token:)
-      expect(response[:error]).to be_blank
+    context 'when immediate_school_onboarding is FALSE' do
+      # before do
+      #   allow(FeatureFlags).to receive(:immediate_school_onboarding?).and_return(false)
+      # end
+
+      it 'does return an error message in the operation response' do
+        ClimateControl.modify(ENABLE_IMMEDIATE_SCHOOL_ONBOARDING: 'false') do
+          response = described_class.call(school:, school_teacher_params:, token:)
+          expect(response[:error]).to match(/is not verified/)
+        end
+      end
+    end
+
+    context 'when immediate_school_onboarding is TRUE' do
+      it 'does not return an error message in the operation response' do
+        ClimateControl.modify(ENABLE_IMMEDIATE_SCHOOL_ONBOARDING: 'true') do
+          response = described_class.call(school:, school_teacher_params:, token:)
+          expect(response[:error]).to be_blank
+        end
+      end
     end
   end
 end