Skip to content

Commit 3d8abd2

Browse files
committed
slght refactor to fix rubocop
1 parent e930dcd commit 3d8abd2

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

app/controllers/api/lessons_controller.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ def index
1212
ordered_scope = scope.order(created_at: :asc)
1313

1414
accessible_lessons = ordered_scope.accessible_by(current_ability)
15-
lessons_with_users = accessible_lessons.with_users
16-
remixes = user_remixes(accessible_lessons)
17-
@lessons_with_users_and_remixes = lessons_with_users.zip(remixes)
15+
@lessons_with_users = accessible_lessons.with_users
1816
if current_user&.school_teacher?(school) || current_user&.school_owner?(school)
1917
render :teacher_index, formats: [:json], status: :ok
2018
else
19+
remixes = user_remixes(accessible_lessons)
20+
@lessons_with_users_and_remixes = @lessons_with_users.zip(remixes)
2121
render :student_index, formats: [:json], status: :ok
2222
end
2323
end
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# frozen_string_literal: true
22

3-
json.array!(@lessons_with_users_and_remixes) do |lesson_with_user, remix|
4-
lesson, user = lesson_with_user
3+
json.array!(@lessons_with_users) do |lesson, user|
54
json.partial! 'lesson', lesson: lesson, user: user
65
json.submitted_count(lesson.submitted_count)
76
end

0 commit comments

Comments
 (0)