Stop swallowing errors from tasks

We have had lots of intermittent test failures on these tasks. These tasks are all swallowing their errors which makes it difficult to debug.

We could make the tests output the rails log to standard out or make the log available after but this will make the output hard to match up to the individual test.

Generally we shouldn't swallow errors like this as it makes it difficult to debug and easy for tests to pass for the wrong reasons.

The transaction will work as before as any error raised in a transaction will call a rollback.

Author: zetter-rpf

lib/tasks/for_education.rake

@@ -41,9 +41,6 @@ namespace :for_education do
       School.find(school_id).destroy
 
       Rails.logger.info 'Done...'
-    rescue StandardError => e
-      Rails.logger.error "Failed: #{e.message}"
-      raise ActiveRecord::Rollback
     end
   end
 
@@ -60,9 +57,6 @@ namespace :for_education do
       create_school(creator_id, TEST_SCHOOL)
 
       Rails.logger.info 'Done...'
-    rescue StandardError => e
-      Rails.logger.error "Failed: #{e.message}"
-      raise ActiveRecord::Rollback
     end
   end
 
@@ -80,9 +74,6 @@ namespace :for_education do
       school = create_school(creator_id, TEST_SCHOOL)
       verify_school(school)
       Rails.logger.info 'Done...'
-    rescue StandardError => e
-      Rails.logger.error "Failed: #{e.message}"
-      raise ActiveRecord::Rollback
     end
   end
 
@@ -110,9 +101,6 @@ namespace :for_education do
         create_project(creator_id, school, lesson)
       end
       Rails.logger.info 'Done...'
-    rescue StandardError => e
-      Rails.logger.error "Failed: #{e.message}"
-      raise ActiveRecord::Rollback
     end
   end
 end

lib/tasks/test_seeds.rake

@@ -39,10 +39,6 @@ namespace :test_seeds do
       School.where(id: school_ids).destroy_all
 
       Rails.logger.info 'Done...'
-    rescue StandardError => e
-      pp "Failed: #{e.message}"
-      Rails.logger.error "Failed: #{e.message}"
-      raise ActiveRecord::Rollback
     end
   end
 
@@ -74,9 +70,6 @@ namespace :test_seeds do
         end
       end
       Rails.logger.info 'Done...'
-    rescue StandardError => e
-      Rails.logger.error "Failed: #{e.message}"
-      raise ActiveRecord::Rollback
     end
   end
 end