Retain BYPASS_OAUTH funcationlity but defer to stubs.

Author: fspeirs

lib/user_info_api_client.rb

@@ -7,6 +7,7 @@ class UserInfoApiClient
   class << self
     def fetch_by_ids(user_ids)
       return [] if user_ids.blank?
+      return stubbed_users(user_ids) if bypass_oauth?
 
       response = conn.get do |r|
         r.url '/users'
@@ -19,6 +20,7 @@ def fetch_by_ids(user_ids)
 
     def find_user_by_email(email)
       return nil if email.blank?
+      return stubbed_user_by_email(email) if bypass_oauth?
 
       response = conn.get do |r|
         r.url "/users/#{CGI.escape(email)}"
@@ -34,6 +36,10 @@ def find_user_by_email(email)
 
     private
 
+    def bypass_oauth?
+      ENV.fetch('BYPASS_OAUTH', nil) == 'true'
+    end
+
     def transform_user(user)
       user.transform_keys { |k| k.to_s.underscore.to_sym }
     end
@@ -53,5 +59,17 @@ def conn
         f.response :json # decode response bodies as JSON
       end
     end
+
+    # Development/test stubbing methods - only active when BYPASS_OAUTH=true
+    # Delegates to UserInfoApiMock to avoid code duplication
+    def stubbed_users(user_ids)
+      require_relative '../spec/support/user_info_api_mock' unless defined?(UserInfoApiMock)
+      UserInfoApiMock.default_stubbed_users(user_ids)
+    end
+
+    def stubbed_user_by_email(email)
+      require_relative '../spec/support/user_info_api_mock' unless defined?(UserInfoApiMock)
+      UserInfoApiMock.default_stubbed_user_by_email(email)
+    end
   end
 end

spec/models/user_spec.rb

@@ -73,6 +73,23 @@
       it 'returns a user without a username' do
         expect(user.username).to be_nil
       end
+
+      context 'when BYPASS_OAUTH is true' do
+        around do |example|
+          ClimateControl.modify(BYPASS_OAUTH: 'true') do
+            example.run
+          end
+        end
+
+        it 'does not call the API' do
+          user
+          expect(WebMock).not_to have_requested(:get, /.*/)
+        end
+
+        it 'returns a stubbed user' do
+          expect(user.name).to eq('School Owner')
+        end
+      end
     end
 
     context 'when logged into a student account' do
@@ -353,6 +370,25 @@
     it 'returns a user with the correct email' do
       expect(user.email).to eq 'school-owner@example.com'
     end
+
+    context 'when BYPASS_OAUTH is true' do
+      around do |example|
+        ClimateControl.modify(BYPASS_OAUTH: 'true') do
+          example.run
+        end
+      end
+
+      let(:owner) { create(:owner, school:, id: '00000000-0000-0000-0000-000000000000') }
+
+      it 'does not call the API' do
+        user
+        expect(WebMock).not_to have_requested(:get, /.*/)
+      end
+
+      it 'returns a stubbed user' do
+        expect(user.name).to eq('School Owner')
+      end
+    end
   end
 
   describe '#schools' do

spec/support/user_info_api_mock.rb

@@ -50,4 +50,7 @@ def default_stubbed_user(id:, email:)
       roles: ''
     }
   end
+
+  # Class methods for use by UserInfoApiClient when BYPASS_OAUTH=true
+  module_function :default_stubbed_users, :default_stubbed_user_by_email, :default_stubbed_user
 end