Refactor SchoolImportJob to use SchoolVerificationService directly instead of duplicating.

Author: fspeirs

app/jobs/school_import_job.rb

@@ -8,7 +8,8 @@ class SchoolImportJob < ApplicationJob
 
   queue_as :import_schools_job
 
-  def perform(schools_data:, user_id:)
+  def perform(schools_data:, user_id:, token:)
+    @token = token
     @results = {
       successful: [],
       failed: []
@@ -76,11 +77,8 @@ def import_school(school_data)
       if result.success?
         school = result[:school]
 
-        # Auto-verify the imported school
-        school.verify!
-
-        # Create owner role
-        Role.owner.create!(school_id: school.id, user_id: owner[:id])
+        # Auto-verify the imported school using the verification service
+        SchoolVerificationService.new(school).verify(token: @token)
 
         @results[:successful] << {
           name: school.name,

lib/concepts/school/operations/import_batch.rb

@@ -24,7 +24,7 @@ def call(csv_file:, current_user:)
 
         job = enqueue_import_job(
           schools_data: parsed_schools[:schools],
-          user_id: current_user.id
+          current_user: current_user
         )
 
         response[:job_id] = job.job_id
@@ -151,10 +151,11 @@ def validate_email_format(data, errors)
         errors << { field: 'owner_email', message: 'invalid email format' }
       end
 
-      def enqueue_import_job(schools_data:, user_id:)
+      def enqueue_import_job(schools_data:, current_user:)
         SchoolImportJob.perform_later(
           schools_data: schools_data,
-          user_id: user_id
+          user_id: current_user.id,
+          token: current_user.token
         )
       end
     end

spec/concepts/school/import_batch_spec.rb

@@ -38,7 +38,8 @@
               hash_including(name: 'Test School 1'),
               hash_including(name: 'Test School 2')
             ),
-            user_id: current_user.id
+            user_id: current_user.id,
+            token: current_user.token
           )
         )
       end

spec/jobs/school_import_job_spec.rb

@@ -38,13 +38,16 @@
       allow(UserInfoApiClient).to receive(:find_user_by_email)
         .with('owner2@example.com')
         .and_return({ id: owner2_id, email: 'owner2@example.com' })
+
+      allow(ProfileApiClient).to receive(:create_school).and_return(true)
     end
 
     context 'when all schools can be created successfully' do
       it 'creates schools and returns successful results' do
         results = described_class.new.perform(
           schools_data: schools_data,
-          user_id: user_id
+          user_id: user_id,
+          token: token
         )
 
         expect(results[:successful].count).to eq(2)
@@ -56,8 +59,9 @@
         expect(school_1.code).to be_present
         expect(school_1.user_origin).to eq('experience_cs')
 
-        # Check owner role was created
+        # Check owner and teacher roles were created
         expect(Role.owner.exists?(school_id: school_1.id, user_id: owner1_id)).to be true
+        expect(Role.teacher.exists?(school_id: school_1.id, user_id: owner1_id)).to be true
       end
     end
 
@@ -71,7 +75,8 @@
       it 'adds failed result for that school' do
         results = described_class.new.perform(
           schools_data: [schools_data.first],
-          user_id: user_id
+          user_id: user_id,
+          token: token
         )
 
         expect(results[:successful].count).to eq(0)
@@ -91,7 +96,8 @@
       it 'adds failed result for that school' do
         results = described_class.new.perform(
           schools_data: [schools_data.first],
-          user_id: user_id
+          user_id: user_id,
+          token: token
         )
 
         expect(results[:successful].count).to eq(0)
@@ -125,7 +131,8 @@
       it 'handles string keys correctly' do
         results = described_class.new.perform(
           schools_data: schools_data_with_string_keys,
-          user_id: user_id
+          user_id: user_id,
+          token: token
         )
 
         expect(results[:successful].count).to eq(1)